Issue 2915073003: Merge-60 [Payments] Use C++ metric enums in Java.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2915073003: Merge-60 [Payments] Use C++ metric enums in Java. (Closed)

Created:
3 years, 6 months ago by sebsg

Modified:
3 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3112

Project:
chromium

Visibility:
Public.

More Reviews

Description

Merge-60 [Payments] Use C++ metric enums in Java. BUG=726771 Review-Url: https://codereview.chromium.org/2904083003 Cr-Original-Commit-Position: refs/heads/master@{#476034} Review-Url: https://codereview.chromium.org/2915073003 . Cr-Commit-Position: refs/branch-heads/3112@{#99} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/101da67741a368c1e658065350dea1c5940f0a0e

Patch Set 1 #

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+244 lines, -360 lines)			Patch
M	chrome/BUILD.gn	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/android/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java	View	9 chunks	+7 lines, -82 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java	View	29 chunks	+37 lines, -38 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java	View	3 chunks	+8 lines, -35 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestCanMakePaymentMetricsTest.java	View	6 chunks	+18 lines, -18 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java	View	1 chunk	+8 lines, -12 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java	View	1 chunk	+7 lines, -10 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailAndFreeShippingTest.java	View	1 chunk	+2 lines, -7 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailAndPhoneTest.java	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailTest.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java	View	10 chunks	+10 lines, -15 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsUnitTest.java	View	1 chunk	+42 lines, -76 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNameAndFreeShippingTest.java	View	1 chunk	+2 lines, -7 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNameTest.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneAndFreeShippingTest.java	View	1 chunk	+2 lines, -7 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneTest.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShowTwiceTest.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestCommon.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/payments/payment_request_can_make_payment_metrics_browsertest.cc	View	8 chunks	+12 lines, -11 lines	0 comments	Download
M	components/payments/core/journey_logger.h	View	5 chunks	+52 lines, -13 lines	0 comments	Download
M	components/payments/core/journey_logger.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	components/payments/core/journey_logger_unittest.cc	View	8 chunks	+12 lines, -11 lines	0 comments	Download
M	tools/android/eclipse/.classpath	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sebsg

3 years, 6 months ago (2017-06-01 18:26:26 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
101da67741a368c1e658065350dea1c5940f0a0e.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages