Fix FeedbackCollectorTest#testGatheringOfDataNoScreenshot

Fix FeedbackCollectorTest#testGatheringOfDataNoScreenshot

This test was added in https://codereview.chromium.org/2897323002/ but was
making incorrect assets. That is, when we're not expecting screeshots, the
results from the connectivity task should trigger the test callback.

It was passing locally because of timing. The things we were checking for in
the tests would be set once FeedbackCollector#maybePostResult would post task a
call to the callback in the test. The incorrect assert would be made before the
callback would get called.

TBR=nyquist@chromium.org
BUG=726704
Review-Url: https://codereview.chromium.org/2906903002
Cr-Original-Commit-Position: refs/heads/master@{#475015}
Review-Url: https://codereview.chromium.org/2915063002 .
Cr-Commit-Position: refs/branch-heads/3112@{#90}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
Committed: https://chromium.googlesource.com/chromium/src/+/37b290974a762400695340bb7ac4585087e02b85

[ymalik, 2017-06-01 15:11:14]

Description was changed from

==========
Fix FeedbackCollectorTest#testGatheringOfDataNoScreenshot

This test was added in https://codereview.chromium.org/2897323002/ but was
making incorrect assets. That is, when we're not expecting screeshots, the
results from the connectivity task should trigger the test callback.

It was passing locally because of timing. The things we were checking for in
the tests would be set once FeedbackCollector#maybePostResult would post task a
call to the callback in the test. The incorrect assert would be made before the
callback would get called.

TBR=nyquist@chromium.org
BUG=726704

Review-Url: https://codereview.chromium.org/2906903002
Cr-Commit-Position: refs/heads/master@{#475015}
(cherry picked from commit ac576561b36502cca1a685ab92d3ef9f03546154)
==========

to

==========
Fix FeedbackCollectorTest#testGatheringOfDataNoScreenshot

This test was added in https://codereview.chromium.org/2897323002/ but was
making incorrect assets. That is, when we're not expecting screeshots, the
results from the connectivity task should trigger the test callback.

It was passing locally because of timing. The things we were checking for in
the tests would be set once FeedbackCollector#maybePostResult would post task a
call to the callback in the test. The incorrect assert would be made before the
callback would get called.

TBR=nyquist@chromium.org
BUG=726704

Review-Url: https://codereview.chromium.org/2906903002
Cr-Original-Commit-Position: refs/heads/master@{#475015}
Review-Url: https://codereview.chromium.org/2915063002 .
Cr-Commit-Position: refs/branch-heads/3112@{#90}
Cr-Branched-From:
b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
Committed:
https://chromium.googlesource.com/chromium/src/+/37b290974a762400695340bb7ac4...
==========

[ymalik, 2017-06-01 15:11:19]

Committed patchset #1 (id:1) manually as
37b290974a762400695340bb7ac4585087e02b85.