Fix FeedbackCollectorTest#testGatheringOfDataNoScreenshot

Fix FeedbackCollectorTest#testGatheringOfDataNoScreenshot

This test was added in https://codereview.chromium.org/2897323002/ but was
making incorrect assets. That is, when we're not expecting screeshots, the
results from the connectivity task should trigger the test callback.

It was passing locally because of timing. The things we were checking for in
the tests would be set once FeedbackCollector#maybePostResult would post task a
call to the callback in the test. The incorrect assert would be made before the
callback would get called.

TBR=nyquist@chromium.org
BUG=726704
Review-Url: https://codereview.chromium.org/2906903002
Cr-Commit-Position: refs/heads/master@{#475015}
Committed: https://chromium.googlesource.com/chromium/src/+/ac576561b36502cca1a685ab92d3ef9f03546154

[ymalik, 2017-05-26 15:13:01]

The CQ bit was checked by ymalik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 15:13:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ymalik, 2017-05-26 15:13:33]

Description was changed from

==========
Fix FeedbackCollectorTest#testGatheringOfDataNoScreenshot

This test was added in https://codereview.chromium.org/2897323002/ but was
making incorrect assets. That is, when we're not expecting screeshots, the
results from the connectivity task should trigger the test callback.

It was passing locally because of timing. The things we were checking for in
the tests would be set once FeedbackCollector#maybePostResult would post task a
call to the callback in the test. The incorrect assert would be made before the
callback would get called.

BUG=726704
==========

to

==========
Fix FeedbackCollectorTest#testGatheringOfDataNoScreenshot

This test was added in https://codereview.chromium.org/2897323002/ but was
making incorrect assets. That is, when we're not expecting screeshots, the
results from the connectivity task should trigger the test callback.

It was passing locally because of timing. The things we were checking for in
the tests would be set once FeedbackCollector#maybePostResult would post task a
call to the callback in the test. The incorrect assert would be made before the
callback would get called.

TBR=nyquist@chromium.org
BUG=726704
==========

[commit-bot: I haz the power, 2017-05-26 15:52:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 15:52:28]

Dry run: This issue passed the CQ dry run.

[ymalik, 2017-05-26 15:53:38]

The CQ bit was checked by ymalik@chromium.org

[commit-bot: I haz the power, 2017-05-26 15:54:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 15:58:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495814018384460, "parent_rev":
"afc52f4ebf737fb545461fa2a5041d8ce08f5386", "commit_rev":
"ac576561b36502cca1a685ab92d3ef9f03546154"}

[commit-bot: I haz the power, 2017-05-26 15:58:52]

Description was changed from

==========
Fix FeedbackCollectorTest#testGatheringOfDataNoScreenshot

This test was added in https://codereview.chromium.org/2897323002/ but was
making incorrect assets. That is, when we're not expecting screeshots, the
results from the connectivity task should trigger the test callback.

It was passing locally because of timing. The things we were checking for in
the tests would be set once FeedbackCollector#maybePostResult would post task a
call to the callback in the test. The incorrect assert would be made before the
callback would get called.

TBR=nyquist@chromium.org
BUG=726704
==========

to

==========
Fix FeedbackCollectorTest#testGatheringOfDataNoScreenshot

This test was added in https://codereview.chromium.org/2897323002/ but was
making incorrect assets. That is, when we're not expecting screeshots, the
results from the connectivity task should trigger the test callback.

It was passing locally because of timing. The things we were checking for in
the tests would be set once FeedbackCollector#maybePostResult would post task a
call to the callback in the test. The incorrect assert would be made before the
callback would get called.

TBR=nyquist@chromium.org
BUG=726704

Review-Url: https://codereview.chromium.org/2906903002
Cr-Commit-Position: refs/heads/master@{#475015}
Committed:
https://chromium.googlesource.com/chromium/src/+/ac576561b36502cca1a685ab92d3...
==========

[commit-bot: I haz the power, 2017-05-26 15:58:53]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ac576561b36502cca1a685ab92d3...

[nyquist, 2017-06-01 17:48:01]

nyquist@chromium.org changed reviewers:
+ nyquist@chromium.org

[nyquist, 2017-06-01 17:48:01]

lgtm