Put TextIteratorTextNodeHandler and TextIteratorTextState on heap

Put TextIteratorTextNodeHandler and TextIteratorTextState on heap

This patch puts TextIteratorTextNodeHandle and TextIteratorTextState on heap,
so that we can use forward declaration, and also opens up possibility for
switching them to a Layout NG version.

Note: we can't only put TextIteratorTextNodeHandler on heap because it holds
a reference to TextIteratorTextState, but an on-heap object cannot hold reference
to a stack-allocated object.

BUG=721957
TEST=n/a; no behavioral change

Review-Url: https://codereview.chromium.org/2915043004
Cr-Commit-Position: refs/heads/master@{#476605}
Committed: https://chromium.googlesource.com/chromium/src/+/c7fee9a6165a732a2cb346c9db63ab65adab5398

[Xiaocheng, 2017-06-01 18:48:48]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 18:49:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 20:52:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 20:52:03]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-06-01 20:56:14]

Description was changed from

==========
Put TextIteratorTextNodeHandler and TextIteratorTextState on heap

BUG=
==========

to

==========
Put TextIteratorTextNodeHandler and TextIteratorTextState on heap

This patch puts TextIteratorTextNodeHandle and TextIteratorTextState on heap,
so that we can use forward declaration, and also opens up possibility for
switching them to a Layout NG version.

Note: we can't only put TextIteratorTextNodeHandler on heap because it holds
a reference to TextIteratorTextState, but an on-heap object cannot hold
reference
to a stack-allocated object.

BUG=721957
TEST=n/a; no behavioral change
==========

[Xiaocheng, 2017-06-01 20:56:21]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-06-01 20:56:21]

PTAL.

[yosin_UTC9, 2017-06-02 04:33:03]

lgtm w/ nits

https://codereview.chromium.org/2915043004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/iterators/TextIterator.h (right):

https://codereview.chromium.org/2915043004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/iterators/TextIterator.h:232:
Member<TextIteratorTextState> text_state_;
nit: s/Member/const Member/

https://codereview.chromium.org/2915043004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/iterators/TextIterator.h:235:
Member<TextIteratorTextNodeHandler> text_node_handler_;
nit: s/Member/const Member/

https://codereview.chromium.org/2915043004/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.h
(right):

https://codereview.chromium.org/2915043004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.h:102:
Member<TextIteratorTextState> text_state_;
nit: s/Member/const Member/

[Xiaocheng, 2017-06-02 05:15:49]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2017-06-02 05:15:50]

Thanks for reviewing!

https://codereview.chromium.org/2915043004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/iterators/TextIterator.h (right):

https://codereview.chromium.org/2915043004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/iterators/TextIterator.h:232:
Member<TextIteratorTextState> text_state_;
On 2017/06/02 at 04:33:03, yosin_UTC9 wrote:
> nit: s/Member/const Member/

Done.

https://codereview.chromium.org/2915043004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/iterators/TextIterator.h:235:
Member<TextIteratorTextNodeHandler> text_node_handler_;
On 2017/06/02 at 04:33:02, yosin_UTC9 wrote:
> nit: s/Member/const Member/

Done.

https://codereview.chromium.org/2915043004/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.h
(right):

https://codereview.chromium.org/2915043004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.h:102:
Member<TextIteratorTextState> text_state_;
On 2017/06/02 at 04:33:03, yosin_UTC9 wrote:
> nit: s/Member/const Member/

Done.

[Xiaocheng, 2017-06-02 05:15:51]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2915043004/#ps20001
(title: "const Member<>")

[commit-bot: I haz the power, 2017-06-02 05:16:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 08:48:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496380549718300,
"parent_rev": "22f51252c62761cc2ff93fe9752377626705c480", "commit_rev":
"c7fee9a6165a732a2cb346c9db63ab65adab5398"}

[commit-bot: I haz the power, 2017-06-02 08:48:27]

Description was changed from

==========
Put TextIteratorTextNodeHandler and TextIteratorTextState on heap

This patch puts TextIteratorTextNodeHandle and TextIteratorTextState on heap,
so that we can use forward declaration, and also opens up possibility for
switching them to a Layout NG version.

Note: we can't only put TextIteratorTextNodeHandler on heap because it holds
a reference to TextIteratorTextState, but an on-heap object cannot hold
reference
to a stack-allocated object.

BUG=721957
TEST=n/a; no behavioral change
==========

to

==========
Put TextIteratorTextNodeHandler and TextIteratorTextState on heap

This patch puts TextIteratorTextNodeHandle and TextIteratorTextState on heap,
so that we can use forward declaration, and also opens up possibility for
switching them to a Layout NG version.

Note: we can't only put TextIteratorTextNodeHandler on heap because it holds
a reference to TextIteratorTextState, but an on-heap object cannot hold
reference
to a stack-allocated object.

BUG=721957
TEST=n/a; no behavioral change

Review-Url: https://codereview.chromium.org/2915043004
Cr-Commit-Position: refs/heads/master@{#476605}
Committed:
https://chromium.googlesource.com/chromium/src/+/c7fee9a6165a732a2cb346c9db63...
==========

[commit-bot: I haz the power, 2017-06-02 08:48:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c7fee9a6165a732a2cb346c9db63...