third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.h - Issue 2915043004: Put TextIteratorTextNodeHandler and TextIteratorTextState on heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.h

Issue 2915043004: Put TextIteratorTextNodeHandler and TextIteratorTextState on heap (Closed)

Patch Set: const Member<> Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/iterators/TextIteratorTextNodeHandler.cpp ('k') | third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.h

diff --git a/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.h b/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.h

index aeff02db3375801cdcfe6545256cc71dd813ca73..f81bb8fed902e50b89d21c3fbbd61b9589dc192d 100644

--- a/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.h

+++ b/third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.h

@@ -38,9 +38,8 @@ namespace blink {

class LayoutText;

class TextIteratorBehavior;

-class CORE_EXPORT TextIteratorTextState {

- STACK_ALLOCATED();

+class CORE_EXPORT TextIteratorTextState

+ : public GarbageCollectedFinalized<TextIteratorTextState> {

public:

explicit TextIteratorTextState(const TextIteratorBehavior&);

~TextIteratorTextState() {}

@@ -79,6 +78,8 @@ class CORE_EXPORT TextIteratorTextState {

unsigned position,

unsigned length_to_append) const;

+ DECLARE_TRACE();

private:

int text_length_ = 0;

String text_;