Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2915023002: PlzNavigate: Remove DumpWithoutCrashing() (Closed)

Created:
3 years, 6 months ago by arthursonzogni
Modified:
3 years, 6 months ago
Reviewers:
clamy
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: Remove DumpWithoutCrashing() Since https://crbug.com/705508 is fixed, this DumpWithoutCrashing() can be removed. It was introduced in https://crrev.com/2805693002. BUG=705508 R=clamy@chromium.org Review-Url: https://codereview.chromium.org/2915023002 Cr-Commit-Position: refs/heads/master@{#478310} Committed: https://chromium.googlesource.com/chromium/src/+/fb9653132754cf5796f2aeb1c9b97b0b307acc53

Patch Set 1 #

Patch Set 2 : Rebase and fix conflicts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M content/child/web_url_loader_impl.cc View 1 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
arthursonzogni
Hi Camille, Could you please review this?
3 years, 6 months ago (2017-06-01 08:26:03 UTC) #1
clamy
Thanks for the cleanup! LGTM.
3 years, 6 months ago (2017-06-09 14:46:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2915023002/1
3 years, 6 months ago (2017-06-09 14:47:18 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/228858) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 6 months ago (2017-06-09 14:49:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2915023002/20001
3 years, 6 months ago (2017-06-09 14:57:25 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 16:56:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fb9653132754cf5796f2aeb1c9b9...

Powered by Google App Engine
This is Rietveld 408576698