Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: content/child/web_url_loader_impl.cc

Issue 2915023002: PlzNavigate: Remove DumpWithoutCrashing() (Closed)
Patch Set: Rebase and fix conflicts. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/web_url_loader_impl.cc
diff --git a/content/child/web_url_loader_impl.cc b/content/child/web_url_loader_impl.cc
index acd699d37d54cedb4f76fb1e7e756eaa2130948e..5a380418d28d011a9ddcdc29c4ad4f6b2ec163bb 100644
--- a/content/child/web_url_loader_impl.cc
+++ b/content/child/web_url_loader_impl.cc
@@ -13,7 +13,6 @@
#include <vector>
#include "base/bind.h"
-#include "base/debug/dump_without_crashing.h"
#include "base/files/file_path.h"
#include "base/logging.h"
#include "base/memory/ptr_util.h"
@@ -616,17 +615,6 @@ void WebURLLoaderImpl::Context::Start(const WebURLRequest& request,
}
}
- // PlzNavigate: Invalid renderer main resource requests are rejected by the
- // browser. This should not happen.
- // TODO(arthursonzogni): Remove this when the root cause for
- // https://crbug.com/705508 is found.
- if (IsBrowserSideNavigationEnabled() &&
- IsResourceTypeFrame(resource_request->resource_type) &&
- !resource_request->resource_body_stream_url.SchemeIs(url::kBlobScheme) &&
- !consumer_handle.is_valid()) {
- base::debug::DumpWithoutCrashing();
- }
-
RequestExtraData empty_extra_data;
RequestExtraData* extra_data;
if (request.GetExtraData())
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698