Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2914963002: Allow web-midi permission to be granted to insecure origins (Closed)

Created:
3 years, 6 months ago by raymes
Modified:
3 years, 6 months ago
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org, raymes+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow web-midi permission to be granted to insecure origins https://codereview.chromium.org/2897833002 unintentionally broke WebMidi for insecure origins. This CL fixes that and adds a test. BUG=727699 Review-Url: https://codereview.chromium.org/2914963002 Cr-Commit-Position: refs/heads/master@{#476184} Committed: https://chromium.googlesource.com/chromium/src/+/5cb31a1c6f558ac77ff4f2ef20dab5899428aa46

Patch Set 1 #

Patch Set 2 : Allow web-midi permission to be granted to insecure origins #

Patch Set 3 : Allow web-midi permission to be granted to insecure origins #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -11 lines) Patch
M chrome/browser/media/midi_permission_context.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/media/midi_permission_context_unittest.cc View 1 2 1 chunk +47 lines, -0 lines 0 comments Download
D chrome/browser/media/midi_sysex_permission_context_unittest.cc View 1 2 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
raymes
3 years, 6 months ago (2017-05-31 23:51:24 UTC) #2
Sergey Ulanov
lgtm
3 years, 6 months ago (2017-06-01 00:03:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914963002/40001
3 years, 6 months ago (2017-06-01 01:21:31 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/5cb31a1c6f558ac77ff4f2ef20dab5899428aa46
3 years, 6 months ago (2017-06-01 04:04:24 UTC) #8
Takashi Toyoshima
3 years, 6 months ago (2017-06-01 06:02:51 UTC) #9
Message was sent while issue was closed.
thank you for a quick fix.
lgtm!

Powered by Google App Engine
This is Rietveld 408576698