Add a PermissionContext subclass for the midi permission

Add a PermissionContext subclass for the midi permission

This adds a PermissionContext subclass for the midi permission, removing the
special casing from PermissionManager. This is necessary because the midi
permission will have a feature policy associated with it and feature policy
will take effect in the PermissionContext subclass in
GetPermissionStatusInternal. It needs to live here so that the permission
status checks in PermissionContextBase::RequestPermission return the
correct values. It is also just where all other permission checks live (like
secure origin, kill switch, etc.).

BUG=689802
Review-Url: https://codereview.chromium.org/2897833002
Cr-Commit-Position: refs/heads/master@{#475272}
Committed: https://chromium.googlesource.com/chromium/src/+/c2cf640fde6976075f3b8876ed68eec9d0e97a61

[raymes, 2017-05-22 03:03:42]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 03:03:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[raymes, 2017-05-22 03:06:46]

Description was changed from

==========
Add a PermissionContext subclass for the midi permission

This adds a PermissionContext subclass for the midi permission, removing the
special casing from PermissionManager. This is necessary because the midi
permission will have a feature policy associated with it and feature policy
will take effect in the PermissionContext subclass along with other permission
checks (like secure origin, kill switch, etc.).

BUG=689802
==========

to

==========
Add a PermissionContext subclass for the midi permission

This adds a PermissionContext subclass for the midi permission, removing the
special casing from PermissionManager. This is necessary because the midi
permission will have a feature policy associated with it and feature policy
will take effect in the PermissionContext subclass in
GetPermissionStatusInternal. It needs to live here so that the permission
status checks in PermissionContextBase::RequestPermission return the
correct values. It is also just where all other permission checks live (like
secure origin, kill switch, etc.).

BUG=689802
==========

[commit-bot: I haz the power, 2017-05-22 03:14:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 03:15:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[raymes, 2017-05-22 04:10:07]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 04:10:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 05:12:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 05:12:54]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[raymes, 2017-05-23 00:33:02]

The CQ bit was checked by raymes@chromium.org to run a CQ dry run

[raymes, 2017-05-23 00:33:07]

raymes@chromium.org changed reviewers:
+ timloh@chromium.org

[commit-bot: I haz the power, 2017-05-23 00:34:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 01:48:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 01:48:54]

Dry run: This issue passed the CQ dry run.

[Timothy Loh, 2017-05-23 03:24:52]

On 2017/05/23 00:33:08, raymes wrote:

lgtm

[raymes, 2017-05-24 01:03:03]

The CQ bit was checked by raymes@chromium.org

[raymes, 2017-05-24 01:03:06]

The CQ bit was unchecked by raymes@chromium.org

[raymes, 2017-05-24 01:04:09]

raymes@chromium.org changed reviewers:
+ sergeyu@chromium.org

[raymes, 2017-05-24 01:04:09]

+sergeyu for c/b/media

[Sergey Ulanov, 2017-05-25 18:41:23]

lgtm

https://codereview.chromium.org/2897833002/diff/50001/chrome/browser/media/mi...
File chrome/browser/media/midi_permission_context.cc (right):

https://codereview.chromium.org/2897833002/diff/50001/chrome/browser/media/mi...
chrome/browser/media/midi_permission_context.cc:1: // Copyright 2017 The
Chromium Authors. All rights reserved.
nit: copyright year doesn't need to be changed when you edit a file

https://codereview.chromium.org/2897833002/diff/50001/chrome/browser/media/mi...
chrome/browser/media/midi_permission_context.cc:17: return
CONTENT_SETTING_ALLOW;
Does this mean that MIDI permission is automatically granted to all pages that
request it? Is that what we want here?

[Sergey Ulanov, 2017-05-25 18:43:10]

One more copyright header issue.

https://codereview.chromium.org/2897833002/diff/50001/chrome/browser/media/mi...
File chrome/browser/media/midi_sysex_permission_context.h (right):

https://codereview.chromium.org/2897833002/diff/50001/chrome/browser/media/mi...
chrome/browser/media/midi_sysex_permission_context.h:1: // Copyright 2013 The
Chromium Authors. All rights reserved.
2017 - this is a new file. Some for other new files.

[raymes, 2017-05-29 00:26:10]

https://codereview.chromium.org/2897833002/diff/50001/chrome/browser/media/mi...
File chrome/browser/media/midi_permission_context.cc (right):

https://codereview.chromium.org/2897833002/diff/50001/chrome/browser/media/mi...
chrome/browser/media/midi_permission_context.cc:1: // Copyright 2017 The
Chromium Authors. All rights reserved.
On 2017/05/25 18:41:22, Sergey Ulanov wrote:
> nit: copyright year doesn't need to be changed when you edit a file

Done.

https://codereview.chromium.org/2897833002/diff/50001/chrome/browser/media/mi...
chrome/browser/media/midi_permission_context.cc:17: return
CONTENT_SETTING_ALLOW;
On 2017/05/25 18:41:23, Sergey Ulanov wrote:
> Does this mean that MIDI permission is automatically granted to all pages that
> request it? Is that what we want here?

Yes - that is what happens for MIDI today. We show a prompt for MIDI_SYSEX
though.

https://codereview.chromium.org/2897833002/diff/50001/chrome/browser/media/mi...
File chrome/browser/media/midi_sysex_permission_context.h (right):

https://codereview.chromium.org/2897833002/diff/50001/chrome/browser/media/mi...
chrome/browser/media/midi_sysex_permission_context.h:1: // Copyright 2013 The
Chromium Authors. All rights reserved.
On 2017/05/25 18:43:10, Sergey Ulanov wrote:
> 2017 - this is a new file. Some for other new files.

Done.

[raymes, 2017-05-29 00:27:38]

The CQ bit was checked by raymes@chromium.org

[raymes, 2017-05-29 00:27:39]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org,
sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/2897833002/#ps70001
(title: "Midi sysex")

[commit-bot: I haz the power, 2017-05-29 00:27:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 01:35:32]

CQ is committing da patch.

Bot data: {"patchset_id": 70001, "attempt_start_ts": 1496017658691890,
"parent_rev": "7eb6069bf8afee2521bcc856488c45b1f43ae6e6", "commit_rev":
"c2cf640fde6976075f3b8876ed68eec9d0e97a61"}

[commit-bot: I haz the power, 2017-05-29 01:35:44]

Description was changed from

==========
Add a PermissionContext subclass for the midi permission

This adds a PermissionContext subclass for the midi permission, removing the
special casing from PermissionManager. This is necessary because the midi
permission will have a feature policy associated with it and feature policy
will take effect in the PermissionContext subclass in
GetPermissionStatusInternal. It needs to live here so that the permission
status checks in PermissionContextBase::RequestPermission return the
correct values. It is also just where all other permission checks live (like
secure origin, kill switch, etc.).

BUG=689802
==========

to

==========
Add a PermissionContext subclass for the midi permission

This adds a PermissionContext subclass for the midi permission, removing the
special casing from PermissionManager. This is necessary because the midi
permission will have a feature policy associated with it and feature policy
will take effect in the PermissionContext subclass in
GetPermissionStatusInternal. It needs to live here so that the permission
status checks in PermissionContextBase::RequestPermission return the
correct values. It is also just where all other permission checks live (like
secure origin, kill switch, etc.).

BUG=689802

Review-Url: https://codereview.chromium.org/2897833002
Cr-Commit-Position: refs/heads/master@{#475272}
Committed:
https://chromium.googlesource.com/chromium/src/+/c2cf640fde6976075f3b8876ed68...
==========

[commit-bot: I haz the power, 2017-05-29 01:35:45]

Committed patchset #5 (id:70001) as
https://chromium.googlesource.com/chromium/src/+/c2cf640fde6976075f3b8876ed68...