Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2914613002: Add keyword_subset field template and generate text-decoration-line. (Closed)

Created:
3 years, 6 months ago by shend
Modified:
3 years, 5 months ago
Reviewers:
meade_UTC10, nainar
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add keyword_subset field template and generate text-decoration-line. This patch adds support for generating 'keyword_subset' fields in ComputedStyleBase. 'keyword_subset' fields can take on a subset of keywords. For example, the text-decoration-line property can be any combination of underline, overline, line-through or blink. To support 'keyword_subset', we create a new class in the generator called Enum to represent both 'keyword' and 'keyword_subset' enums. In ComputedStyleBaseConstants.h.tmpl, we generate different code depending on whether the enum is a set or not. Unlike 'keyword' enums, a 'keyword_subset' enum has explicit values and supports bitwise operators. Diff of generated files: https://gist.github.com/darrnshn/70d7a9e1ef02aee205b5c1d42d4df3bb/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2914613002 Cr-Commit-Position: refs/heads/master@{#484037} Committed: https://chromium.googlesource.com/chromium/src/+/3cbb82af46309fd12ccbe36fd6434844ddf645a1

Patch Set 1 #

Total comments: 7

Patch Set 2 : Address comments #

Patch Set 3 : Forgot CSSValueID mappings #

Patch Set 4 : Mappings #

Patch Set 5 : Rename #

Patch Set 6 : Rebase #

Messages

Total messages: 39 (30 generated)
shend
Hi Naina, PTAL
3 years, 6 months ago (2017-05-30 03:44:08 UTC) #5
nainar
lgtm with rename nits https://codereview.chromium.org/2914613002/diff/1/third_party/WebKit/Source/build/scripts/make_computed_style_base.py File third_party/WebKit/Source/build/scripts/make_computed_style_base.py (right): https://codereview.chromium.org/2914613002/diff/1/third_party/WebKit/Source/build/scripts/make_computed_style_base.py#newcode78 third_party/WebKit/Source/build/scripts/make_computed_style_base.py:78: """Represents a generated enum in ...
3 years, 6 months ago (2017-05-30 04:13:46 UTC) #6
shend
Hi Eddy, PTAL https://codereview.chromium.org/2914613002/diff/1/third_party/WebKit/Source/build/scripts/make_computed_style_base.py File third_party/WebKit/Source/build/scripts/make_computed_style_base.py (right): https://codereview.chromium.org/2914613002/diff/1/third_party/WebKit/Source/build/scripts/make_computed_style_base.py#newcode82 third_party/WebKit/Source/build/scripts/make_computed_style_base.py:82: self.is_set = is_set On 2017/05/30 at ...
3 years, 6 months ago (2017-05-31 07:52:07 UTC) #12
meade_UTC10
lgtm with nits It took me a while to figure out what a "keyword_subset" value ...
3 years, 6 months ago (2017-06-02 03:59:17 UTC) #22
shend
On 2017/06/02 at 03:59:17, meade wrote: > lgtm with nits > > It took me ...
3 years, 6 months ago (2017-06-02 04:04:35 UTC) #23
meade_UTC10
On 2017/06/02 04:04:35, shend wrote: > On 2017/06/02 at 03:59:17, meade wrote: > > lgtm ...
3 years, 6 months ago (2017-06-02 04:16:29 UTC) #24
shend
On 2017/06/02 at 04:16:29, meade wrote: > On 2017/06/02 04:04:35, shend wrote: > > On ...
3 years, 5 months ago (2017-07-04 01:13:09 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914613002/100001
3 years, 5 months ago (2017-07-04 01:13:28 UTC) #36
commit-bot: I haz the power
3 years, 5 months ago (2017-07-04 01:19:57 UTC) #39
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/3cbb82af46309fd12ccbe36fd643...

Powered by Google App Engine
This is Rietveld 408576698