Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSProperties.json5

Issue 2914613002: Add keyword_subset field template and generate text-decoration-line. (Closed)
Patch Set: Rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 { 1 {
2 // This file specifies all the CSS properties we support and the necessary 2 // This file specifies all the CSS properties we support and the necessary
3 // information for our code generation. The various supported arguments 3 // information for our code generation. The various supported arguments
4 // are described below with example usage 4 // are described below with example usage
5 5
6 parameters: { 6 parameters: {
7 // - alias_for: "other-property" 7 // - alias_for: "other-property"
8 // Properties specifying alias_for should be virtually identical to the 8 // Properties specifying alias_for should be virtually identical to the
9 // properties they alias. Minor parsing differences are allowed as long as 9 // properties they alias. Minor parsing differences are allowed as long as
10 // the CSSValues created are of the same format of the aliased property. 10 // the CSSValues created are of the same format of the aliased property.
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 // - field_template 80 // - field_template
81 // Affects how the interface to this field is generated. 81 // Affects how the interface to this field is generated.
82 // TODO(sashab, meade): Remove this once TypedOM types are specified for 82 // TODO(sashab, meade): Remove this once TypedOM types are specified for
83 // every property, since this value can be inferred from that. 83 // every property, since this value can be inferred from that.
84 field_template: { 84 field_template: {
85 valid_values: [ 85 valid_values: [
86 // Field is stored as an enum and has a initial/getter/setter/resetter. 86 // Field is stored as an enum and has a initial/getter/setter/resetter.
87 // If include_paths is empty, we would also generate the corresponding 87 // If include_paths is empty, we would also generate the corresponding
88 // enum definition in ComputedStyleConstants.h. 88 // enum definition in ComputedStyleConstants.h.
89 "keyword", 89 "keyword",
90 // Field can take on any subset of values from a list of keywords.
91 "multi_keyword",
90 // Field stores a primitive value like int/bool. The type is specified b y 92 // Field stores a primitive value like int/bool. The type is specified b y
91 // type_name. The interface has a initial/getter/setter/resetter. 93 // type_name. The interface has a initial/getter/setter/resetter.
92 "primitive", 94 "primitive",
93 // Field is stored as a bool, whose default value is false 95 // Field is stored as a bool, whose default value is false
94 // and can only be set to true. Has a initial/getter/setter. 96 // and can only be set to true. Has a initial/getter/setter.
95 "monotonic_flag", 97 "monotonic_flag",
96 // Field has type specified at type_name and has a getter/setter. 98 // Field has type specified at type_name and has a getter/setter.
97 // Also has a setter taking an rvalue reference. Cannot be packed. 99 // Also has a setter taking an rvalue reference. Cannot be packed.
98 "external", 100 "external",
99 // Only the storage is generated. The interface is handwritten. 101 // Only the storage is generated. The interface is handwritten.
(...skipping 2446 matching lines...) Expand 10 before | Expand all | Expand 10 after
2546 field_group: "rare-non-inherited", 2548 field_group: "rare-non-inherited",
2547 default_value: "StyleColor::CurrentColor()", 2549 default_value: "StyleColor::CurrentColor()",
2548 }, 2550 },
2549 { 2551 {
2550 name: "text-decoration-line", 2552 name: "text-decoration-line",
2551 api_class: "CSSPropertyAPITextDecorationLine", 2553 api_class: "CSSPropertyAPITextDecorationLine",
2552 converter: "ConvertFlags<TextDecoration>", 2554 converter: "ConvertFlags<TextDecoration>",
2553 name_for_methods: "TextDecoration", 2555 name_for_methods: "TextDecoration",
2554 runtime_flag: "CSS3TextDecorations", 2556 runtime_flag: "CSS3TextDecorations",
2555 type_name: "TextDecoration", 2557 type_name: "TextDecoration",
2556 field_template: "storage_only", 2558 field_template: "multi_keyword",
2557 field_size: 4, 2559 default_value: "none",
2558 default_value: "TextDecoration::kNone", 2560 keywords: ["none", "underline", "overline", "line-through", "blink"],
2559 field_group: "visual", 2561 field_group: "visual",
2560 }, 2562 },
2561 { 2563 {
2562 name: "text-decoration-skip", 2564 name: "text-decoration-skip",
2563 api_class: true, 2565 api_class: true,
2564 api_methods: ["parseSingleValue"], 2566 api_methods: ["parseSingleValue"],
2565 converter: "ConvertFlags<TextDecorationSkip>", 2567 converter: "ConvertFlags<TextDecorationSkip>",
2566 inherited: true, 2568 inherited: true,
2567 runtime_flag: "CSS3TextDecorations", 2569 runtime_flag: "CSS3TextDecorations",
2568 field_template: "storage_only", 2570 field_template: "storage_only",
(...skipping 1645 matching lines...) Expand 10 before | Expand all | Expand 10 after
4214 { 4216 {
4215 name: "-webkit-transition-timing-function", 4217 name: "-webkit-transition-timing-function",
4216 alias_for: "transition-timing-function", 4218 alias_for: "transition-timing-function",
4217 }, 4219 },
4218 { 4220 {
4219 name: "-webkit-user-select", 4221 name: "-webkit-user-select",
4220 alias_for: "user-select", 4222 alias_for: "user-select",
4221 }, 4223 },
4222 ], 4224 ],
4223 } 4225 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h ('k') | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698