Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issue 2914593003: Add usage guideline comments for custom GL context priority. (Closed)

Created:
3 years, 6 months ago by klausw
Modified:
3 years, 6 months ago
Reviewers:
jbauman
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add usage guideline comments for custom GL context priority. Due to conflicts with the GVR library, we had to stop using this for the VR browser mode. I think this attribute is still useful for the future, but we should use it to reduce priority of possibly-slow user GL code instead of using "high" priority ourselves. BUG=725684 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2914593003 Cr-Commit-Position: refs/heads/master@{#475801} Committed: https://chromium.googlesource.com/chromium/src/+/a54463e34bc265ab1c63a192f449042136ab1528

Patch Set 1 #

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M ui/gl/gl_context.h View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
klausw
3 years, 6 months ago (2017-05-30 18:51:39 UTC) #3
jbauman
lgtm
3 years, 6 months ago (2017-05-30 22:10:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914593003/20001
3 years, 6 months ago (2017-05-30 23:16:51 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/306515)
3 years, 6 months ago (2017-05-31 02:02:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914593003/20001
3 years, 6 months ago (2017-05-31 03:42:08 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 04:28:50 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a54463e34bc265ab1c63a192f449...

Powered by Google App Engine
This is Rietveld 408576698