Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2914573003: M59: Revert of "Replace homebrew scrollbar in Files app with that of Blink." (Closed)

Created:
3 years, 6 months ago by yamaguchi
Modified:
3 years, 6 months ago
Reviewers:
fukino
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

M59: Revert of "Replace homebrew scrollbar in Files app with that of Blink." (patchset #3 id:40001 of https://codereview.chromium.org/2782063002/ ) Reason for revert: We don't enable native overlay scrollbar by default on M59. The Files app should continue using the older scrollbar that was built for the app. Original issue's description: > Reland of "Replace homebrew scrollbar in Files app with that of Blink." > > This changelist is based on the revert patch of commit e50697019dd8e4092b07607e7cf9f3f4fbc8aef5. > > > BUG=666589 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2782063002 > Cr-Commit-Position: refs/heads/master@{#460290} > Committed: https://chromium.googlesource.com/chromium/src/+/c4faf5fee6fab54abd2e49a5e2170434c0440914 # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=684695 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2914573003 Cr-Commit-Position: refs/branch-heads/3071@{#733} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/47e91004c618d26d32ce0a7d1803720affa72489

Patch Set 1 #

Patch Set 2 : Revert of "Replace homebrew scrollbar in Files app with that of Blink." (patchset #3 id:40001 of ht… #

Messages

Total messages: 33 (28 generated)
yamaguchi
Created Revert of "Replace homebrew scrollbar in Files app with that of Blink."
3 years, 6 months ago (2017-05-30 03:41:34 UTC) #1
yamaguchi
ptal
3 years, 6 months ago (2017-05-30 05:11:32 UTC) #21
fukino
lgtm
3 years, 6 months ago (2017-05-30 07:17:50 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914573003/170001
3 years, 6 months ago (2017-06-01 00:52:44 UTC) #30
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 00:53:29 UTC) #33
Message was sent while issue was closed.
Committed patchset #2 (id:170001) as
https://chromium.googlesource.com/chromium/src/+/47e91004c618d26d32ce0a7d1803...

Powered by Google App Engine
This is Rietveld 408576698