Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2782063002: Reland of "Replace homebrew scrollbar in Files app with that of Blink." (Closed)

Created:
3 years, 8 months ago by yamaguchi
Modified:
3 years, 8 months ago
Reviewers:
fukino
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of "Replace homebrew scrollbar in Files app with that of Blink." This changelist is based on the revert patch of commit e50697019dd8e4092b07607e7cf9f3f4fbc8aef5. BUG=666589 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2782063002 Cr-Commit-Position: refs/heads/master@{#460290} Committed: https://chromium.googlesource.com/chromium/src/+/c4faf5fee6fab54abd2e49a5e2170434c0440914

Patch Set 1 : Created a patch using git revert. #

Total comments: 1

Patch Set 2 : Remove a hack to make scrollbars composited, as it's no longer needed. #

Patch Set 3 : Remove the 'scrollbar' target in compiled_resources2.gyp. #

Messages

Total messages: 23 (16 generated)
yamaguchi
ptal https://codereview.chromium.org/2782063002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css File ui/file_manager/file_manager/foreground/css/file_manager.css (right): https://codereview.chromium.org/2782063002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css#newcode132 ui/file_manager/file_manager/foreground/css/file_manager.css:132: /* TODO(yamaguchi): Remove these when crbug.com/671644 is resolved. ...
3 years, 8 months ago (2017-03-29 03:43:20 UTC) #10
fukino
lgtm. Thank you!
3 years, 8 months ago (2017-03-29 04:05:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782063002/40001
3 years, 8 months ago (2017-03-29 04:09:45 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 8 months ago (2017-03-29 04:34:22 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2782063002/40001
3 years, 8 months ago (2017-03-29 05:33:38 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/c4faf5fee6fab54abd2e49a5e2170434c0440914
3 years, 8 months ago (2017-03-29 05:42:39 UTC) #22
yamaguchi
3 years, 6 months ago (2017-05-30 03:41:34 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2914573003/ by yamaguchi@chromium.org.

The reason for reverting is: We don't enable native overlay scrollbar by default
on M59..

Powered by Google App Engine
This is Rietveld 408576698