Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 291453002: Make ExtensionFunction::ArgumentList (PKA MultipleArguments) take a scoped_ptr (Closed)

Created:
6 years, 7 months ago by not at google - send to devlin
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Make ExtensionFunction::ArgumentList (PKA MultipleArguments) take a scoped_ptr rather than a raw pointer, because it plays better with the JSON schema compiler generated code. Also add a TwoArguments method, and rename SingleArgument to OneArgument to be consistent with that. BUG=365732 R=rockot@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271757

Patch Set 1 #

Patch Set 2 : automation #

Patch Set 3 : reabse #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -46 lines) Patch
M apps/shell/browser/api/shell/shell_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/automation_internal/automation_internal_api.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_extension_function.cc View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/browser/api/runtime/runtime_api.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M extensions/browser/api/storage/storage_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/extension_function.h View 3 chunks +17 lines, -7 lines 0 comments Download
M extensions/browser/extension_function.cc View 4 chunks +29 lines, -21 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
not at google - send to devlin
WDYT, too egregious? The reason I make the "Single" --> "One" naming change is so ...
6 years, 7 months ago (2014-05-19 20:11:26 UTC) #1
Ken Rockot(use gerrit already)
On 2014/05/19 20:11:26, kalman wrote: > WDYT, too egregious? The reason I make the "Single" ...
6 years, 7 months ago (2014-05-19 22:19:29 UTC) #2
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 7 months ago (2014-05-19 23:24:54 UTC) #3
not at google - send to devlin
On 2014/05/19 22:19:29, Ken Rockot wrote: > On 2014/05/19 20:11:26, kalman wrote: > > WDYT, ...
6 years, 7 months ago (2014-05-19 23:24:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/291453002/20001
6 years, 7 months ago (2014-05-19 23:25:48 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 04:19:51 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 04:25:19 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/30470)
6 years, 7 months ago (2014-05-20 04:25:19 UTC) #8
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 7 months ago (2014-05-20 18:17:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/291453002/40001
6 years, 7 months ago (2014-05-20 18:18:37 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 21:31:52 UTC) #11
Message was sent while issue was closed.
Change committed as 271757

Powered by Google App Engine
This is Rietveld 408576698