chrome/browser/extensions/api/automation_internal/automation_internal_api.cc - Issue 291453002: Make ExtensionFunction::ArgumentList (PKA MultipleArguments) take a scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/automation_internal/automation_internal_api.cc

Issue 291453002: Make ExtensionFunction::ArgumentList (PKA MultipleArguments) take a scoped_ptr (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: reabse Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/automation_internal/automation_internal_api.cc

diff --git a/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc b/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc

index 9a59de2925c881a1e755d89436078f32382b132f..5ceb58e94fd37849a1b8098749386d4dced08142 100644

--- a/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc

+++ b/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc

@@ -76,10 +76,9 @@ AutomationInternalEnableCurrentTabFunction::Run() {

return RespondNow(Error("Could not enable accessibility for active tab"));

AutomationWebContentsObserver::CreateForWebContents(contents);

rwh->EnableTreeOnlyAccessibilityMode();

- scoped_ptr<base::ListValue> results =

- api::automation_internal::EnableCurrentTab::Results::Create(

- rwh->GetProcess()->GetID(), rwh->GetRoutingID());

- return RespondNow(MultipleArguments(results.release()));

+ return RespondNow(

+ ArgumentList(api::automation_internal::EnableCurrentTab::Results::Create(

+ rwh->GetProcess()->GetID(), rwh->GetRoutingID())));

}

ExtensionFunction::ResponseAction

« no previous file with comments | « apps/shell/browser/api/shell/shell_api.cc ('k') | chrome/browser/extensions/api/identity/identity_api.cc » ('j') | no next file with comments »