chrome/browser/extensions/chrome_extension_function.cc - Issue 291453002: Make ExtensionFunction::ArgumentList (PKA MultipleArguments) take a scoped_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_extension_function.cc

Issue 291453002: Make ExtensionFunction::ArgumentList (PKA MultipleArguments) take a scoped_ptr (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: reabse Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/chrome_extension_function.cc

diff --git a/chrome/browser/extensions/chrome_extension_function.cc b/chrome/browser/extensions/chrome_extension_function.cc

index 0f5a503bed9bfac329dc5d96561713fa39066340..849314fff8f267a653af687713860ba01338deda 100644

--- a/chrome/browser/extensions/chrome_extension_function.cc

+++ b/chrome/browser/extensions/chrome_extension_function.cc

@@ -131,8 +131,7 @@ ChromeSyncExtensionFunction::ChromeSyncExtensionFunction() {

ChromeSyncExtensionFunction::~ChromeSyncExtensionFunction() {}

ExtensionFunction::ResponseAction ChromeSyncExtensionFunction::Run() {

- return RespondNow(RunSync() ? MultipleArguments(results_.get())

- : Error(error_));

+ return RespondNow(RunSync() ? ArgumentList(results_.Pass()) : Error(error_));

}

// static

« no previous file with comments | « chrome/browser/extensions/api/identity/identity_api.cc ('k') | extensions/browser/api/runtime/runtime_api.cc » ('j') | no next file with comments »