Adding phase info to wheel events migrated to wheel phase handler class.

Adding phase info to wheel events migrated to wheel phase handler class.

This cl contains a new class which is responsible for adding timer based
phase info to WebMouseWheelEvents before they are dispatched. The
following two cls do this for aura and mac.
https://codereview.chromium.org/2882443002/
https://codereview.chromium.org/2902303002/

This cl moves those code to a single class to support android as well.
To test it for mac and aura previously added tests are still valid.
No unittest is available for render_widget_host_view_android.cc
BUG=526463
TESTS=RenderWidgetHostViewAuraWheelScrollLatchingEnabledTest.
    TimerBasedWheelEventPhaseInfo/TouchpadFlingStartStopsWheelPhaseTimer/
    GSBWithTouchSourceStopsWheelScrollSequence,
    RenderWidgetHostViewMacWithWheelScrollLatchingEnabledTest.
	 WheelWithPhaseEndedIsNotForwardedImmediately/
	WheelWithMomentumPhaseBeganStopsTheWheelEndDispatchTimer/
	WheelWithPhaseBeganDispatchesThePendingWheelEnd

Review-Url: https://codereview.chromium.org/2914393002
Cr-Commit-Position: refs/heads/master@{#477669}
Committed: https://chromium.googlesource.com/chromium/src/+/09de0d0195a0c0f032611a87794ade22dbc63ef7

[sahel, 2017-06-02 17:14:09]

The CQ bit was checked by sahel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 17:14:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sahel, 2017-06-02 17:17:16]

Description was changed from

==========
Adding phase info to wheel events migrated to wheel phase handler class.

This cl contains a new class which is responsible for adding timer based
phase info to WebMouseWheelEvents before they are dispatched. The
following two cls do this for aura and mac.
https://codereview.chromium.org/2882443002/
https://codereview.chromium.org/2902303002/

This cl moves those code to a single class to support android as well.
BUG=526463
==========

to

==========
Adding phase info to wheel events migrated to wheel phase handler class.

This cl contains a new class which is responsible for adding timer based
phase info to WebMouseWheelEvents before they are dispatched. The
following two cls do this for aura and mac.
https://codereview.chromium.org/2882443002/
https://codereview.chromium.org/2902303002/

This cl moves those code to a single class to support android as well.
To test it for mac and aura previously added tests are still valid.
No unittest is available for render_widget_host_view_android.cc
BUG=526463
TESTS=RenderWidgetHostViewAuraWheelScrollLatchingEnabledTest.
    TimerBasedWheelEventPhaseInfo/TouchpadFlingStartStopsWheelPhaseTimer/
    GSBWithTouchSourceStopsWheelScrollSequence,
    RenderWidgetHostViewMacWithWheelScrollLatchingEnabledTest.
	 WheelWithPhaseEndedIsNotForwardedImmediately/
	WheelWithMomentumPhaseBeganStopsTheWheelEndDispatchTimer/
	WheelWithPhaseBeganDispatchesThePendingWheelEnd
==========

[sahel, 2017-06-02 17:32:26]

The CQ bit was checked by sahel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 17:32:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sahel, 2017-06-02 17:33:36]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-06-02 17:53:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 17:53:01]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[sahel, 2017-06-02 20:47:27]

The CQ bit was checked by sahel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 20:48:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sahel, 2017-06-02 22:46:00]

sahel@chromium.org changed reviewers:
+ tdresser@chromium.org

[commit-bot: I haz the power, 2017-06-03 00:51:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-03 00:51:35]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[tdresser, 2017-06-05 15:19:09]

This is going to be a great cleanup, thanks!

How much trouble would it be to add a render_widget_host_view_android_unittest?

I think it might just not exist cause no one has bothered to create it, and
there's no time like the present.

https://codereview.chromium.org/2914393002/diff/40001/content/browser/rendere...
File content/browser/renderer_host/mouse_wheel_phase_handler.h (right):

https://codereview.chromium.org/2914393002/diff/40001/content/browser/rendere...
content/browser/renderer_host/mouse_wheel_phase_handler.h:10: #include
"content/browser/renderer_host/render_widget_host_impl.h"
Forward declare instead of include.

https://codereview.chromium.org/2914393002/diff/40001/content/browser/rendere...
content/browser/renderer_host/mouse_wheel_phase_handler.h:11: #include
"content/browser/renderer_host/render_widget_host_view_base.h"
Forward declare instead of include.

https://codereview.chromium.org/2914393002/diff/40001/content/browser/rendere...
content/browser/renderer_host/mouse_wheel_phase_handler.h:21:
RenderWidgetHostViewBase* host_view);
Should the parameters be const?

https://codereview.chromium.org/2914393002/diff/40001/content/browser/rendere...
content/browser/renderer_host/mouse_wheel_phase_handler.h:29: bool
HasPendingWheelEndEvent() {
Can this be const?

https://codereview.chromium.org/2914393002/diff/40001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_event_handler.h
(right):

https://codereview.chromium.org/2914393002/diff/40001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_event_handler.h:253:
std::unique_ptr<MouseWheelPhaseHandler> mouse_wheel_phase_handler_;
Why use a unique_ptr here? Why not just stack allocate it?

https://codereview.chromium.org/2914393002/diff/40001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_mac.h (right):

https://codereview.chromium.org/2914393002/diff/40001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_mac.h:437:
std::unique_ptr<MouseWheelPhaseHandler> mouse_wheel_phase_handler_;
Why a unique_ptr?

[sahel, 2017-06-05 19:02:46]

The CQ bit was checked by sahel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 19:03:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sahel, 2017-06-05 19:05:44]

As we talked, wheel events are not common for Android and the
browser test in
https://codereview.chromium.org/2909563002/diff/70012/content/browser/rendere...
covers the end to end behavior for added phase and targeting wheel events based
on their phase info.

https://codereview.chromium.org/2914393002/diff/40001/content/browser/rendere...
File content/browser/renderer_host/mouse_wheel_phase_handler.h (right):

https://codereview.chromium.org/2914393002/diff/40001/content/browser/rendere...
content/browser/renderer_host/mouse_wheel_phase_handler.h:10: #include
"content/browser/renderer_host/render_widget_host_impl.h"
On 2017/06/05 15:19:08, tdresser wrote:
> Forward declare instead of include.

Done.

https://codereview.chromium.org/2914393002/diff/40001/content/browser/rendere...
content/browser/renderer_host/mouse_wheel_phase_handler.h:11: #include
"content/browser/renderer_host/render_widget_host_view_base.h"
On 2017/06/05 15:19:08, tdresser wrote:
> Forward declare instead of include.

Done.

https://codereview.chromium.org/2914393002/diff/40001/content/browser/rendere...
content/browser/renderer_host/mouse_wheel_phase_handler.h:21:
RenderWidgetHostViewBase* host_view);
On 2017/06/05 15:19:08, tdresser wrote:
> Should the parameters be const?

Done.

https://codereview.chromium.org/2914393002/diff/40001/content/browser/rendere...
content/browser/renderer_host/mouse_wheel_phase_handler.h:29: bool
HasPendingWheelEndEvent() {
On 2017/06/05 15:19:08, tdresser wrote:
> Can this be const?

Done.

https://codereview.chromium.org/2914393002/diff/40001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_event_handler.h
(right):

https://codereview.chromium.org/2914393002/diff/40001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_event_handler.h:253:
std::unique_ptr<MouseWheelPhaseHandler> mouse_wheel_phase_handler_;
On 2017/06/05 15:19:08, tdresser wrote:
> Why use a unique_ptr here? Why not just stack allocate it?

Done.

https://codereview.chromium.org/2914393002/diff/40001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_mac.h (right):

https://codereview.chromium.org/2914393002/diff/40001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_mac.h:437:
std::unique_ptr<MouseWheelPhaseHandler> mouse_wheel_phase_handler_;
On 2017/06/05 15:19:08, tdresser wrote:
> Why a unique_ptr?

Done.

[commit-bot: I haz the power, 2017-06-05 19:16:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 19:16:34]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[tdresser, 2017-06-05 19:19:01]

LGTM

[sahel, 2017-06-05 19:27:58]

The CQ bit was checked by sahel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 19:28:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 00:09:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 00:09:26]

Dry run: This issue passed the CQ dry run.

[sahel, 2017-06-06 14:42:39]

sahel@chromium.org changed reviewers:
+ jam@chromium.org

[sahel, 2017-06-06 14:42:40]

jam@chromium.org: Please review changes in 

content/browser/BUILD.gn

[jam, 2017-06-07 01:17:15]

lgtm

[sahel, 2017-06-07 14:32:09]

The CQ bit was checked by sahel@chromium.org

[sahel, 2017-06-07 14:32:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/2914393002/#ps80001
(title: "fixed mouse_wheel_phase_handler_path in rwhv_mac")

[commit-bot: I haz the power, 2017-06-07 14:33:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 16:09:47]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496845929759930,
"parent_rev": "e58ee8dcf36c801caf96cf04f9f5eb6d618b2df8", "commit_rev":
"09de0d0195a0c0f032611a87794ade22dbc63ef7"}

[commit-bot: I haz the power, 2017-06-07 16:10:03]

Description was changed from

==========
Adding phase info to wheel events migrated to wheel phase handler class.

This cl contains a new class which is responsible for adding timer based
phase info to WebMouseWheelEvents before they are dispatched. The
following two cls do this for aura and mac.
https://codereview.chromium.org/2882443002/
https://codereview.chromium.org/2902303002/

This cl moves those code to a single class to support android as well.
To test it for mac and aura previously added tests are still valid.
No unittest is available for render_widget_host_view_android.cc
BUG=526463
TESTS=RenderWidgetHostViewAuraWheelScrollLatchingEnabledTest.
    TimerBasedWheelEventPhaseInfo/TouchpadFlingStartStopsWheelPhaseTimer/
    GSBWithTouchSourceStopsWheelScrollSequence,
    RenderWidgetHostViewMacWithWheelScrollLatchingEnabledTest.
	 WheelWithPhaseEndedIsNotForwardedImmediately/
	WheelWithMomentumPhaseBeganStopsTheWheelEndDispatchTimer/
	WheelWithPhaseBeganDispatchesThePendingWheelEnd
==========

to

==========
Adding phase info to wheel events migrated to wheel phase handler class.

This cl contains a new class which is responsible for adding timer based
phase info to WebMouseWheelEvents before they are dispatched. The
following two cls do this for aura and mac.
https://codereview.chromium.org/2882443002/
https://codereview.chromium.org/2902303002/

This cl moves those code to a single class to support android as well.
To test it for mac and aura previously added tests are still valid.
No unittest is available for render_widget_host_view_android.cc
BUG=526463
TESTS=RenderWidgetHostViewAuraWheelScrollLatchingEnabledTest.
    TimerBasedWheelEventPhaseInfo/TouchpadFlingStartStopsWheelPhaseTimer/
    GSBWithTouchSourceStopsWheelScrollSequence,
    RenderWidgetHostViewMacWithWheelScrollLatchingEnabledTest.
	 WheelWithPhaseEndedIsNotForwardedImmediately/
	WheelWithMomentumPhaseBeganStopsTheWheelEndDispatchTimer/
	WheelWithPhaseBeganDispatchesThePendingWheelEnd

Review-Url: https://codereview.chromium.org/2914393002
Cr-Commit-Position: refs/heads/master@{#477669}
Committed:
https://chromium.googlesource.com/chromium/src/+/09de0d0195a0c0f032611a87794a...
==========

[commit-bot: I haz the power, 2017-06-07 16:10:04]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/09de0d0195a0c0f032611a87794a...