Adding phase info to wheel events migrated to wheel phase handler class.

content/browser/renderer_host/render_widget_host_view_event_handler.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_event_handler.h"
 
 #include "base/metrics/user_metrics.h"
 #include "base/metrics/user_metrics_action.h"
 #include "content/browser/renderer_host/input/touch_selection_controller_client_aura.h"
 #include "content/browser/renderer_host/overscroll_controller.h"
@@ skipping 120 matching lines @@
       disable_input_event_router_for_testing_(false),
       mouse_locked_(false),
       pinch_zoom_enabled_(content::IsPinchToZoomEnabled()),
       set_focus_on_mouse_down_or_key_event_(false),
       synthetic_move_sent_(false),
       host_(RenderWidgetHostImpl::From(host)),
       host_view_(host_view),
       popup_child_host_view_(nullptr),
       popup_child_event_handler_(nullptr),
       delegate_(delegate),
-      window_(nullptr) {}
+      window_(nullptr),
+      mouse_wheel_phase_handler_(host, host_view) {}
 
 RenderWidgetHostViewEventHandler::~RenderWidgetHostViewEventHandler() {}
 
 void RenderWidgetHostViewEventHandler::SetPopupChild(
     RenderWidgetHostViewBase* popup_child_host_view,
     ui::EventHandler* popup_child_event_handler) {
   popup_child_host_view_ = popup_child_host_view;
   popup_child_event_handler_ = popup_child_event_handler;
 }
 
@@ skipping 182 matching lines @@
                         reinterpret_cast<LPARAM>(toplevel_hwnd));
     }
 #endif
     blink::WebMouseWheelEvent mouse_wheel_event =
         ui::MakeWebMouseWheelEvent(static_cast<ui::MouseWheelEvent&>(*event),
                                    base::Bind(&GetScreenLocationFromEvent));
 
     if (mouse_wheel_event.delta_x != 0 || mouse_wheel_event.delta_y != 0) {
       bool should_route_event = ShouldRouteEvent(event);
       if (host_view_->wheel_scroll_latching_enabled())
-        AddPhaseAndScheduleEndEvent(mouse_wheel_event, should_route_event);
+        mouse_wheel_phase_handler_.AddPhaseIfNeededAndScheduleEndEvent(
+            mouse_wheel_event, should_route_event);
       if (should_route_event) {
         host_->delegate()->GetInputEventRouter()->RouteMouseWheelEvent(
             host_view_, &mouse_wheel_event, *event->latency());
       } else {
         ProcessMouseWheelEvent(mouse_wheel_event, *event->latency());
       }
     }
   } else {
     bool is_selection_popup = NeedsInputGrab(popup_child_host_view_);
     if (CanRendererHandleEvent(event, mouse_locked_, is_selection_popup) &&
@@ skipping 48 matching lines @@
 #endif
     blink::WebGestureEvent gesture_event = ui::MakeWebGestureEventFlingCancel();
     // Coordinates need to be transferred to the fling cancel gesture only
     // for Surface-targeting to ensure that it is targeted to the correct
     // RenderWidgetHost.
     gesture_event.x = event->x();
     gesture_event.y = event->y();
     blink::WebMouseWheelEvent mouse_wheel_event = ui::MakeWebMouseWheelEvent(
         *event, base::Bind(&GetScreenLocationFromEvent));
     if (host_view_->wheel_scroll_latching_enabled())
-      AddPhaseAndScheduleEndEvent(mouse_wheel_event, should_route_event);
+      mouse_wheel_phase_handler_.AddPhaseIfNeededAndScheduleEndEvent(
+          mouse_wheel_event, should_route_event);
     if (should_route_event) {
       host_->delegate()->GetInputEventRouter()->RouteGestureEvent(
           host_view_, &gesture_event,
           ui::LatencyInfo(ui::SourceEventType::WHEEL));
       host_->delegate()->GetInputEventRouter()->RouteMouseWheelEvent(
           host_view_, &mouse_wheel_event, *event->latency());
     } else {
       host_->ForwardGestureEvent(gesture_event);
       host_->ForwardWheelEventWithLatencyInfo(mouse_wheel_event,
                                               *event->latency());
     }
   } else if (event->type() == ui::ET_SCROLL_FLING_START ||
              event->type() == ui::ET_SCROLL_FLING_CANCEL) {
     blink::WebGestureEvent gesture_event = ui::MakeWebGestureEvent(
         *event, base::Bind(&GetScreenLocationFromEvent));
     if (should_route_event) {
       host_->delegate()->GetInputEventRouter()->RouteGestureEvent(
           host_view_, &gesture_event,
           ui::LatencyInfo(ui::SourceEventType::WHEEL));
     } else {
       host_->ForwardGestureEvent(gesture_event);
     }
     if (event->type() == ui::ET_SCROLL_FLING_START) {
       RecordAction(base::UserMetricsAction("TrackpadScrollFling"));
-      // Stop the timer to avoid sending a synthetic wheel event with
-      // kPhaseEnded.
-      mouse_wheel_end_dispatch_timer_.Stop();
+      // Ignore the pending wheel end event to avoid sending a wheel event with
+      // kPhaseEnded before a GFS.
+      mouse_wheel_phase_handler_.IgnorePendingWheelEndEvent();
     }
   }
 
   event->SetHandled();
 }
 
 void RenderWidgetHostViewEventHandler::OnTouchEvent(ui::TouchEvent* event) {
   TRACE_EVENT0("input", "RenderWidgetHostViewBase::OnTouchEvent");
 
   bool had_no_pointer = !pointer_state_.GetPointerCount();
@@ skipping 74 matching lines @@
           host_view_, &fling_cancel,
           ui::LatencyInfo(ui::SourceEventType::TOUCH));
     } else {
       host_->ForwardGestureEvent(fling_cancel);
     }
   }
 
   if (gesture.GetType() != blink::WebInputEvent::kUndefined) {
     if (event->type() == ui::ET_GESTURE_SCROLL_BEGIN) {
       RecordAction(base::UserMetricsAction("TouchscreenScroll"));
-
-      if (mouse_wheel_end_dispatch_timer_.IsRunning()) {
-        // If there is a current scroll going on and a new scroll that isn't
-        // wheel based send a synthetic wheel event with kPhaseEnded to cancel
-        // the current scroll.
-        base::Closure task = mouse_wheel_end_dispatch_timer_.user_task();
-        mouse_wheel_end_dispatch_timer_.Stop();
-        task.Run();
-      }
+      // If there is a current scroll going on and a new scroll that isn't
+      // wheel based send a synthetic wheel event with kPhaseEnded to cancel
+      // the current scroll.
+      mouse_wheel_phase_handler_.DispatchPendingWheelEndEvent();
     } else if (event->type() == ui::ET_GESTURE_SCROLL_END) {
       // Make sure that the next wheel event will have phase = |kPhaseBegan|.
       // This is for maintaining the correct phase info when some of the wheel
       // events get ignored while a touchscreen scroll is going on.
-      mouse_wheel_end_dispatch_timer_.Stop();
+      mouse_wheel_phase_handler_.IgnorePendingWheelEndEvent();
     } else if (event->type() == ui::ET_SCROLL_FLING_START) {
       RecordAction(base::UserMetricsAction("TouchscreenScrollFling"));
     }
 
     if (ShouldRouteEvent(event)) {
       host_->delegate()->GetInputEventRouter()->RouteGestureEvent(
           host_view_, &gesture, *event->latency());
     } else {
       host_->ForwardGestureEventWithLatencyInfo(gesture, *event->latency());
     }
@@ skipping 345 matching lines @@
     const ui::LatencyInfo& latency) {
   host_->ForwardWheelEventWithLatencyInfo(event, latency);
 }
 
 void RenderWidgetHostViewEventHandler::ProcessTouchEvent(
     const blink::WebTouchEvent& event,
     const ui::LatencyInfo& latency) {
   host_->ForwardTouchEventWithLatencyInfo(event, latency);
 }
 
-void RenderWidgetHostViewEventHandler::SendSyntheticWheelEventWithPhaseEnded(
-    blink::WebMouseWheelEvent last_mouse_wheel_event,
-    bool should_route_event) {
-  DCHECK(host_view_->wheel_scroll_latching_enabled());
-  blink::WebMouseWheelEvent mouse_wheel_event = last_mouse_wheel_event;
-  mouse_wheel_event.delta_x = 0;
-  mouse_wheel_event.delta_y = 0;
-  mouse_wheel_event.phase = blink::WebMouseWheelEvent::kPhaseEnded;
-  mouse_wheel_event.dispatch_type =
-      blink::WebInputEvent::DispatchType::kEventNonBlocking;
-  if (should_route_event) {
-    host_->delegate()->GetInputEventRouter()->RouteMouseWheelEvent(
-        host_view_, &mouse_wheel_event,
-        ui::LatencyInfo(ui::SourceEventType::WHEEL));
-  } else {
-    ProcessMouseWheelEvent(mouse_wheel_event,
-                           ui::LatencyInfo(ui::SourceEventType::WHEEL));
-  }
-}
-
-void RenderWidgetHostViewEventHandler::AddPhaseAndScheduleEndEvent(
-    blink::WebMouseWheelEvent& mouse_wheel_event,
-    bool should_route_event) {
-  DCHECK_EQ(blink::WebMouseWheelEvent::kPhaseNone, mouse_wheel_event.phase);
-  DCHECK_EQ(blink::WebMouseWheelEvent::kPhaseNone,
-            mouse_wheel_event.momentum_phase);
-
-  if (!mouse_wheel_end_dispatch_timer_.IsRunning()) {
-    mouse_wheel_event.phase = blink::WebMouseWheelEvent::kPhaseBegan;
-    mouse_wheel_end_dispatch_timer_.Start(
-        FROM_HERE,
-        base::TimeDelta::FromMilliseconds(
-            kDefaultMouseWheelLatchingTransactionMs),
-        base::Bind(&RenderWidgetHostViewEventHandler::
-                       SendSyntheticWheelEventWithPhaseEnded,
-                   base::Unretained(this), mouse_wheel_event,
-                   should_route_event));
-  } else {
-    bool non_zero_delta =
-        mouse_wheel_event.delta_x || mouse_wheel_event.delta_y;
-    mouse_wheel_event.phase = non_zero_delta
-                                  ? blink::WebMouseWheelEvent::kPhaseChanged
-                                  : blink::WebMouseWheelEvent::kPhaseStationary;
-    mouse_wheel_end_dispatch_timer_.Reset();
-  }
-}
-
 }  // namespace content