Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 2914213002: Delete the NTPPreferAmpUrls feature flag. (Closed)

Created:
3 years, 6 months ago by Michael van Ouwerkerk
Modified:
3 years, 6 months ago
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete the NTPPreferAmpUrls feature flag. BUG=668095 Review-Url: https://codereview.chromium.org/2914213002 Cr-Commit-Position: refs/heads/master@{#476625} Committed: https://chromium.googlesource.com/chromium/src/+/0b0349c068fe8d724fe27d6d2b2fdd598ca6510b

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -26 lines) Patch
M components/ntp_snippets/features.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M components/ntp_snippets/features.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestion.cc View 2 chunks +1 line, -4 lines 0 comments Download
M testing/variations/fieldtrial_testing_config.json View 1 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
Michael van Ouwerkerk
Bernhard, could you take a look as NTP owner please? Alexei, could you take a ...
3 years, 6 months ago (2017-06-01 14:35:43 UTC) #4
Alexei Svitkine (slow)
lgtm
3 years, 6 months ago (2017-06-01 14:51:06 UTC) #5
Bernhard Bauer
lgtm
3 years, 6 months ago (2017-06-02 10:14:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914213002/1
3 years, 6 months ago (2017-06-02 10:16:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/454265)
3 years, 6 months ago (2017-06-02 10:23:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914213002/20001
3 years, 6 months ago (2017-06-02 10:30:44 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/309118)
3 years, 6 months ago (2017-06-02 11:59:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2914213002/20001
3 years, 6 months ago (2017-06-02 12:25:45 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 13:17:43 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0b0349c068fe8d724fe27d6d2b2f...

Powered by Google App Engine
This is Rietveld 408576698