Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: components/ntp_snippets/features.cc

Issue 2914213002: Delete the NTPPreferAmpUrls feature flag. (Closed)
Patch Set: Rebase. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/ntp_snippets/features.h ('k') | components/ntp_snippets/remote/remote_suggestion.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/ntp_snippets/features.h" 5 #include "components/ntp_snippets/features.h"
6 6
7 #include "base/feature_list.h" 7 #include "base/feature_list.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "base/time/clock.h" 9 #include "base/time/clock.h"
10 #include "components/ntp_snippets/category_rankers/click_based_category_ranker.h " 10 #include "components/ntp_snippets/category_rankers/click_based_category_ranker.h "
11 #include "components/ntp_snippets/category_rankers/constant_category_ranker.h" 11 #include "components/ntp_snippets/category_rankers/constant_category_ranker.h"
12 #include "components/variations/variations_associated_data.h" 12 #include "components/variations/variations_associated_data.h"
13 13
14 namespace ntp_snippets { 14 namespace ntp_snippets {
15 15
16 // Keep sorted, and keep nullptr at the end. 16 // Keep sorted, and keep nullptr at the end.
17 const base::Feature*(kAllFeatures[]) = {&kArticleSuggestionsFeature, 17 const base::Feature*(kAllFeatures[]) = {&kArticleSuggestionsFeature,
18 &kBookmarkSuggestionsFeature, 18 &kBookmarkSuggestionsFeature,
19 &kCategoryOrder, 19 &kCategoryOrder,
20 &kCategoryRanker, 20 &kCategoryRanker,
21 &kContentSuggestionsPushFeature, 21 &kContentSuggestionsPushFeature,
22 &kForeignSessionsSuggestionsFeature, 22 &kForeignSessionsSuggestionsFeature,
23 &kIncreasedVisibility, 23 &kIncreasedVisibility,
24 &kNotificationsFeature, 24 &kNotificationsFeature,
25 &kPhysicalWebPageSuggestionsFeature, 25 &kPhysicalWebPageSuggestionsFeature,
26 &kPreferAmpUrlsFeature,
27 &kPublisherFaviconsFromNewServerFeature, 26 &kPublisherFaviconsFromNewServerFeature,
28 &kRecentOfflineTabSuggestionsFeature, 27 &kRecentOfflineTabSuggestionsFeature,
29 nullptr}; 28 nullptr};
30 29
31 const base::Feature kArticleSuggestionsFeature{ 30 const base::Feature kArticleSuggestionsFeature{
32 "NTPArticleSuggestions", base::FEATURE_ENABLED_BY_DEFAULT}; 31 "NTPArticleSuggestions", base::FEATURE_ENABLED_BY_DEFAULT};
33 32
34 const base::Feature kBookmarkSuggestionsFeature{ 33 const base::Feature kBookmarkSuggestionsFeature{
35 "NTPBookmarkSuggestions", base::FEATURE_ENABLED_BY_DEFAULT}; 34 "NTPBookmarkSuggestions", base::FEATURE_ENABLED_BY_DEFAULT};
36 35
37 const base::Feature kRecentOfflineTabSuggestionsFeature{ 36 const base::Feature kRecentOfflineTabSuggestionsFeature{
38 "NTPOfflinePageSuggestions", base::FEATURE_DISABLED_BY_DEFAULT}; 37 "NTPOfflinePageSuggestions", base::FEATURE_DISABLED_BY_DEFAULT};
39 38
40 const base::Feature kIncreasedVisibility{"NTPSnippetsIncreasedVisibility", 39 const base::Feature kIncreasedVisibility{"NTPSnippetsIncreasedVisibility",
41 base::FEATURE_ENABLED_BY_DEFAULT}; 40 base::FEATURE_ENABLED_BY_DEFAULT};
42 41
43 const base::Feature kPhysicalWebPageSuggestionsFeature{ 42 const base::Feature kPhysicalWebPageSuggestionsFeature{
44 "NTPPhysicalWebPageSuggestions", base::FEATURE_DISABLED_BY_DEFAULT}; 43 "NTPPhysicalWebPageSuggestions", base::FEATURE_DISABLED_BY_DEFAULT};
45 44
46 const base::Feature kForeignSessionsSuggestionsFeature{ 45 const base::Feature kForeignSessionsSuggestionsFeature{
47 "NTPForeignSessionsSuggestions", base::FEATURE_DISABLED_BY_DEFAULT}; 46 "NTPForeignSessionsSuggestions", base::FEATURE_DISABLED_BY_DEFAULT};
48 47
49 const base::Feature kContentSuggestionsPushFeature{ 48 const base::Feature kContentSuggestionsPushFeature{
50 "ContentSuggestionsPush", base::FEATURE_DISABLED_BY_DEFAULT}; 49 "ContentSuggestionsPush", base::FEATURE_DISABLED_BY_DEFAULT};
51 50
52 const base::Feature kPreferAmpUrlsFeature{"NTPPreferAmpUrls",
53 base::FEATURE_ENABLED_BY_DEFAULT};
54
55 const base::Feature kCategoryRanker{"ContentSuggestionsCategoryRanker", 51 const base::Feature kCategoryRanker{"ContentSuggestionsCategoryRanker",
56 base::FEATURE_ENABLED_BY_DEFAULT}; 52 base::FEATURE_ENABLED_BY_DEFAULT};
57 53
58 const base::Feature kPublisherFaviconsFromNewServerFeature{ 54 const base::Feature kPublisherFaviconsFromNewServerFeature{
59 "ContentSuggestionsFaviconsFromNewServer", 55 "ContentSuggestionsFaviconsFromNewServer",
60 base::FEATURE_DISABLED_BY_DEFAULT}; 56 base::FEATURE_DISABLED_BY_DEFAULT};
61 57
62 const char kCategoryRankerParameter[] = "category_ranker"; 58 const char kCategoryRankerParameter[] = "category_ranker";
63 const char kCategoryRankerConstantRanker[] = "constant"; 59 const char kCategoryRankerConstantRanker[] = "constant";
64 const char kCategoryRankerClickBasedRanker[] = "click_based"; 60 const char kCategoryRankerClickBasedRanker[] = "click_based";
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 const char kNotificationsTextValuePublisher[] = "publisher"; 135 const char kNotificationsTextValuePublisher[] = "publisher";
140 const char kNotificationsTextValueSnippet[] = "snippet"; 136 const char kNotificationsTextValueSnippet[] = "snippet";
141 const char kNotificationsTextValueAndMore[] = "and_more"; 137 const char kNotificationsTextValueAndMore[] = "and_more";
142 const char kNotificationsKeepWhenFrontmostParam[] = 138 const char kNotificationsKeepWhenFrontmostParam[] =
143 "keep_notification_when_frontmost"; 139 "keep_notification_when_frontmost";
144 const char kNotificationsOpenToNTPParam[] = "open_to_ntp"; 140 const char kNotificationsOpenToNTPParam[] = "open_to_ntp";
145 const char kNotificationsDailyLimit[] = "daily_limit"; 141 const char kNotificationsDailyLimit[] = "daily_limit";
146 const char kNotificationsIgnoredLimitParam[] = "ignored_limit"; 142 const char kNotificationsIgnoredLimitParam[] = "ignored_limit";
147 143
148 } // namespace ntp_snippets 144 } // namespace ntp_snippets
OLDNEW
« no previous file with comments | « components/ntp_snippets/features.h ('k') | components/ntp_snippets/remote/remote_suggestion.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698