Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: third_party/WebKit/LayoutTests/inspector/network/network-update-calculator-for-all-requests.html

Issue 2914033002: [Devtools] NetworkLogView now uses NetworkLog as source of truth. (Closed)
Patch Set: Merge branch 'master' into MOVE_NETWORK_STUFF_AROUND Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/network/network-update-calculator-for-all-requests.html
diff --git a/third_party/WebKit/LayoutTests/inspector/network/network-update-calculator-for-all-requests.html b/third_party/WebKit/LayoutTests/inspector/network/network-update-calculator-for-all-requests.html
index b4f6e9c7ac004f8ca84046877c69dd65b1f6bbc9..34b35aec2ce7029727d9c8d5dc7007fbbb3b94a7 100644
--- a/third_party/WebKit/LayoutTests/inspector/network/network-update-calculator-for-all-requests.html
+++ b/third_party/WebKit/LayoutTests/inspector/network/network-update-calculator-for-all-requests.html
@@ -7,7 +7,7 @@ function test() {
var target = UI.panels.network._networkLogView;
target._resourceCategoryFilterUI._toggleTypeFilter(Common.resourceTypes.XHR.category().title, false);
InspectorTest.addResult("Clicked '" + Common.resourceTypes.XHR.name() + "' button.");
- target.reset();
+ target._reset();
function appendRequest(id, type, startTime, endTime)
{
@@ -16,10 +16,10 @@ function test() {
request.setRequestId(id);
request.setIssueTime(startTime);
request.endTime = endTime;
- target._appendRequest(request);
+ InspectorTest.networkManager._dispatcher._startNetworkRequest(request);
target._refresh();
- var isFilteredOut = !!target._nodesByRequestId.get(request.requestId())[Network.NetworkLogView._isFilteredOutSymbol];
+ var isFilteredOut = !!target.nodeForRequest(request)[Network.NetworkLogView._isFilteredOutSymbol];
InspectorTest.addResult("");
InspectorTest.addResult("Appended request [" + request.requestId() + "] of type '" + request.resourceType().name() + "' is hidden: " + isFilteredOut + " from [" + request.startTime + "] to [" + request.endTime + "]");
InspectorTest.addResult("Timeline: from [" + target._calculator.minimumBoundary() + "] to [" + target._calculator.maximumBoundary() + "]");

Powered by Google App Engine
This is Rietveld 408576698