Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: third_party/WebKit/LayoutTests/inspector/network/network-filter-updated-requests.html

Issue 2914033002: [Devtools] NetworkLogView now uses NetworkLog as source of truth. (Closed)
Patch Set: Merge branch 'master' into MOVE_NETWORK_STUFF_AROUND Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/network/network-filter-updated-requests.html
diff --git a/third_party/WebKit/LayoutTests/inspector/network/network-filter-updated-requests.html b/third_party/WebKit/LayoutTests/inspector/network/network-filter-updated-requests.html
index 610b327a6cf9c7ced8081f1320878c765087eaf4..15dd824201762b272a41b6f3153c5e5cf1c1b58a 100644
--- a/third_party/WebKit/LayoutTests/inspector/network/network-filter-updated-requests.html
+++ b/third_party/WebKit/LayoutTests/inspector/network/network-filter-updated-requests.html
@@ -3,7 +3,7 @@
<script src="../../http/tests/inspector/inspector-test.js"></script>
<script src="../../http/tests/inspector/network-test.js"></script>
<script>
-function test() {
+async function test() {
var target = UI.panels.network._networkLogView;
var types = Common.resourceTypes;
@@ -14,32 +14,33 @@ function test() {
var requestFoo = new SDK.NetworkRequest(InspectorTest.networkManager, "", "", "", "", "");
requestFoo.setResourceType(types.Script);
requestFoo.setRequestId("foo");
- target._appendRequest(requestFoo);
+ InspectorTest.networkManager._dispatcher._startNetworkRequest(requestFoo);
+
var requestBar = new SDK.NetworkRequest(InspectorTest.networkManager, "", "", "", "", "");
requestBar.setResourceType(types.Script);
requestBar.setRequestId("bar");
- target._appendRequest(requestBar);
- target._refresh();
+ InspectorTest.networkManager._dispatcher._startNetworkRequest(requestBar);
- function isFilteredOut(request) {
- return !!target._nodesByRequestId.get(request.requestId())[Network.NetworkLogView._isFilteredOutSymbol];
+ async function isFilteredOut(request) {
+ var node = await InspectorTest.waitForNetworkLogViewNodeForRequest(request);
+ return !!node[Network.NetworkLogView._isFilteredOutSymbol];
}
InspectorTest.addResult("");
- InspectorTest.addResult("Request [" + requestFoo.requestId() + "] of type '" + requestFoo.resourceType().name() + "' is hidden: " + isFilteredOut(requestFoo));
- InspectorTest.addResult("Request [" + requestBar.requestId() + "] of type '" + requestBar.resourceType().name() + "' is hidden: " + isFilteredOut(requestBar));
+ InspectorTest.addResult("Request [" + requestFoo.requestId() + "] of type '" + requestFoo.resourceType().name() + "' is hidden: " + await isFilteredOut(requestFoo));
+ InspectorTest.addResult("Request [" + requestBar.requestId() + "] of type '" + requestBar.resourceType().name() + "' is hidden: " + await isFilteredOut(requestBar));
InspectorTest.addResult("");
requestFoo.setResourceType(types.XHR);
- target._refreshRequest(requestFoo);
+ InspectorTest.networkManager._dispatcher._updateNetworkRequest(requestFoo);
InspectorTest.addResult("Updated request [" + requestFoo.requestId() + "] type.");
- target._refreshRequest(requestBar);
+ InspectorTest.networkManager._dispatcher._updateNetworkRequest(requestBar);
InspectorTest.addResult("Updated request [" + requestBar.requestId() + "].");
target._refresh();
InspectorTest.addResult("");
- InspectorTest.addResult("Request [" + requestFoo.requestId() + "] of type '" + requestFoo.resourceType().name() + "' is hidden: " + isFilteredOut(requestFoo));
- InspectorTest.addResult("Request [" + requestBar.requestId() + "] of type '" + requestBar.resourceType().name() + "' is hidden: " + isFilteredOut(requestBar));
+ InspectorTest.addResult("Request [" + requestFoo.requestId() + "] of type '" + requestFoo.resourceType().name() + "' is hidden: " + await isFilteredOut(requestFoo));
+ InspectorTest.addResult("Request [" + requestBar.requestId() + "] of type '" + requestBar.resourceType().name() + "' is hidden: " + await isFilteredOut(requestBar));
InspectorTest.completeTest();
}

Powered by Google App Engine
This is Rietveld 408576698