third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js - Issue 2914033002: [Devtools] NetworkLogView now uses NetworkLog as source of truth.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 2914033002: [Devtools] NetworkLogView now uses NetworkLog as source of truth. (Closed)

Patch Set: Merge branch 'master' into MOVE_NETWORK_STUFF_AROUND Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/network/network-update-calculator-for-all-requests.html ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

index b2c8e893b90c9c230474023c36f223ecaf6e84d9..7ed8b30423be3b80b3a89766b9c64061e4ec162d 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

@@ -681,13 +681,8 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {

* @return {boolean}

isNavigationRequest() {

- return this._isNavigationRequest;

- }

- markAsNavigationRequest() {

- this._isNavigationRequest = true;

- this.refresh();

- this._updateBackgroundColor();

+ var pageLoad = NetworkLog.networkLog.pageLoadForRequest(this._request);

+ return pageLoad ? pageLoad.mainRequest === this._request : false;

}

/**