Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Unified Diff: pkg/analysis_server/lib/src/plugin/plugin_manager.dart

Issue 2913913002: Report plugin errors to the instrumentation service (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/instrumentation/instrumentation.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/plugin/plugin_manager.dart
diff --git a/pkg/analysis_server/lib/src/plugin/plugin_manager.dart b/pkg/analysis_server/lib/src/plugin/plugin_manager.dart
index 56ae7eb74ff2b4b2daf994c5fc6e449516921ff1..3f4756bbbd3bb8c20b5a16e3df568514226053a8 100644
--- a/pkg/analysis_server/lib/src/plugin/plugin_manager.dart
+++ b/pkg/analysis_server/lib/src/plugin/plugin_manager.dart
@@ -748,13 +748,8 @@ class PluginSession {
*/
void handleOnError(List<String> errorPair) {
// TODO(brianwilkerson) Decide how we want to handle errors.
-// String message = errorPair[0];
-// String stackTrace = errorPair[1];
-// print('PluginSession.handleOnError');
-// print(' plugin = ${info.executionPath}');
-// print(' $message');
-// print(' ${new StackTrace.fromString(stackTrace)}');
-// pluginStoppedCompleter.completeError(message, new StackTrace.fromString(stackTrace));
+ info.instrumentationService.logPluginException(
+ info.data, errorPair[0], new StackTrace.fromString(errorPair[1]));
}
/**
« no previous file with comments | « no previous file | pkg/analyzer/lib/instrumentation/instrumentation.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698