Report plugin errors to the instrumentation service

pkg/analysis_server/lib/src/plugin/plugin_manager.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:io' show Platform;
 
 import 'package:analysis_server/src/plugin/notification_manager.dart';
 import 'package:analyzer/context/context_root.dart' as analyzer;
@@ skipping 730 matching lines @@
     channel.close();
     channel = null;
     pluginStoppedCompleter.complete(null);
   }
 
   /**
    * Handle the fact that an unhandled error has occurred in the plugin.
    */
   void handleOnError(List<String> errorPair) {
     // TODO(brianwilkerson) Decide how we want to handle errors.
-//    String message = errorPair[0];
-//    String stackTrace = errorPair[1];
-//    print('PluginSession.handleOnError');
-//    print('  plugin = ${info.executionPath}');
-//    print('  $message');
-//    print('  ${new StackTrace.fromString(stackTrace)}');
-//    pluginStoppedCompleter.completeError(message, new StackTrace.fromString(stackTrace));
+    info.instrumentationService.logPluginException(
+        info.data, errorPair[0], new StackTrace.fromString(errorPair[1]));
   }
 
   /**
    * Handle a [response] from the plugin by completing the future that was
    * created when the request was sent.
    */
   void handleResponse(Response response) {
     _PendingRequest requestData = pendingRequests.remove(response.id);
     int responseTime = new DateTime.now().millisecondsSinceEpoch;
     int duration = responseTime - requestData.requestTime;
@@ skipping 116 matching lines @@
    * The completer that will be used to complete the future when the response is
    * received from the plugin.
    */
   final Completer<Response> completer;
 
   /**
    * Initialize a pending request.
    */
   _PendingRequest(this.method, this.requestTime, this.completer);
 }