Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Unified Diff: pkg/analyzer/lib/instrumentation/instrumentation.dart

Issue 2913913002: Report plugin errors to the instrumentation service (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/plugin/plugin_manager.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/instrumentation/instrumentation.dart
diff --git a/pkg/analyzer/lib/instrumentation/instrumentation.dart b/pkg/analyzer/lib/instrumentation/instrumentation.dart
index 4ef7ef985c53660e0ed6f6092568fc6e660544d8..f0337cf9a6b1f1c0c78323ff31874719253cb595 100644
--- a/pkg/analyzer/lib/instrumentation/instrumentation.dart
+++ b/pkg/analyzer/lib/instrumentation/instrumentation.dart
@@ -213,9 +213,16 @@ class InstrumentationService {
*/
void logPluginError(
PluginData plugin, String code, String message, String stackTrace) {
- List<String> fields = <String>[TAG_PLUGIN_ERROR, code, message, stackTrace];
- plugin.addToFields(fields);
- _instrumentationServer.log(_join(fields));
+ if (_instrumentationServer != null) {
+ List<String> fields = <String>[
+ TAG_PLUGIN_ERROR,
+ code,
+ message,
+ stackTrace
+ ];
+ plugin.addToFields(fields);
+ _instrumentationServer.log(_join(fields));
+ }
}
/**
« no previous file with comments | « pkg/analysis_server/lib/src/plugin/plugin_manager.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698