Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2913813002: Ensure the renderer doesn't specify base_url_for_data_url in the BeginNavigation IPC. (Closed)

Created:
3 years, 6 months ago by jam
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Ensure the renderer doesn't specify base_url_for_data_url in the BeginNavigation IPC. This should only be set by browser-initiated navigations. BUG=726142 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2905293002 Cr-Original-Commit-Position: refs/heads/master@{#475043} Review-Url: https://codereview.chromium.org/2913813002 . Cr-Commit-Position: refs/branch-heads/3112@{#30} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/2b180b660e51d20d6a5d95b9121ca57622bfd4da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
M content/browser/bad_message.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/browser_side_navigation_browsertest.cc View 3 chunks +43 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jam
3 years, 6 months ago (2017-05-30 16:19:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2b180b660e51d20d6a5d95b9121ca57622bfd4da.

Powered by Google App Engine
This is Rietveld 408576698