Issue 2913813002: Ensure the renderer doesn't specify base_url_for_data_url in the BeginNavigation IPC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2913813002: Ensure the renderer doesn't specify base_url_for_data_url in the BeginNavigation IPC. (Closed)

Created:
3 years, 6 months ago by jam

Modified:
3 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3112

Project:
chromium

Visibility:
Public.

Ensure the renderer doesn't specify base_url_for_data_url in the BeginNavigation IPC. This should only be set by browser-initiated navigations. BUG=726142 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2905293002 Cr-Original-Commit-Position: refs/heads/master@{#475043} Review-Url: https://codereview.chromium.org/2913813002 . Cr-Commit-Position: refs/branch-heads/3112@{#30} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/2b180b660e51d20d6a5d95b9121ca57622bfd4da

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -0 lines)			Patch
M	content/browser/bad_message.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/browser_side_navigation_browsertest.cc	View	3 chunks	+43 lines, -0 lines	0 comments	Download
M	content/browser/frame_host/render_frame_host_impl.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	tools/metrics/histograms/enums.xml	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

jam

3 years, 6 months ago (2017-05-30 16:19:43 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2b180b660e51d20d6a5d95b9121ca57622bfd4da.