Ensure the renderer doesn't specify base_url_for_data_url in the BeginNavigation IPC.

Ensure the renderer doesn't specify base_url_for_data_url in the BeginNavigation IPC.

This should only be set by browser-initiated navigations.

BUG=726142
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2905293002
Cr-Commit-Position: refs/heads/master@{#475043}
Committed: https://chromium.googlesource.com/chromium/src/+/1a1392222a9b97ffbaa77f3beee093fc81e655ff

[nasko, 2017-05-26 16:24:53]

Description was changed from

==========
Ensure the renderer doesn't specify base_url_for_data_url in the BeginNavigation
IPC.

This should only be set by browser-initiated navigations.

BUG=726142
==========

to

==========
Ensure the renderer doesn't specify base_url_for_data_url in the BeginNavigation
IPC.

This should only be set by browser-initiated navigations.

BUG=726142
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[nasko, 2017-05-26 16:26:02]

The CQ bit was checked by nasko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 16:26:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nasko, 2017-05-26 16:26:35]

nasko@chromium.org changed reviewers:
+ jam@chromium.org

[nasko, 2017-05-26 16:26:36]

This CL just adds a test on top of https://codereview.chromium.org/2905043004/.

[jam, 2017-05-26 16:29:34]

lgtm

lgtm, thanks!

[jam, 2017-05-26 16:29:38]

The CQ bit was unchecked by jam@chromium.org

[jam, 2017-05-26 16:29:40]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-05-26 16:30:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 17:30:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495816180848630, "parent_rev":
"98adf00652d29143b41b6ec77b31e74025f10e93", "commit_rev":
"1a1392222a9b97ffbaa77f3beee093fc81e655ff"}

[commit-bot: I haz the power, 2017-05-26 17:30:33]

Description was changed from

==========
Ensure the renderer doesn't specify base_url_for_data_url in the BeginNavigation
IPC.

This should only be set by browser-initiated navigations.

BUG=726142
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Ensure the renderer doesn't specify base_url_for_data_url in the BeginNavigation
IPC.

This should only be set by browser-initiated navigations.

BUG=726142
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2905293002
Cr-Commit-Position: refs/heads/master@{#475043}
Committed:
https://chromium.googlesource.com/chromium/src/+/1a1392222a9b97ffbaa77f3beee0...
==========

[commit-bot: I haz the power, 2017-05-26 17:30:34]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1a1392222a9b97ffbaa77f3beee0...

[Charlie Reis, 2017-05-30 20:41:47]

creis@chromium.org changed reviewers:
+ creis@chromium.org

[Charlie Reis, 2017-05-30 20:41:48]

https://codereview.chromium.org/2905293002/diff/1/content/browser/frame_host/...
File content/browser/frame_host/render_frame_host_impl.cc (right):

https://codereview.chromium.org/2905293002/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_frame_host_impl.cc:2191: GetProcess(),
bad_message::RFH_BASE_URL_FOR_DATA_URL_SPECIFIED);
This needs a return statement, or we'll continue with the request anyway.

[Charlie Reis, 2017-05-30 20:49:09]

https://codereview.chromium.org/2905293002/diff/1/content/browser/browser_sid...
File content/browser/browser_side_navigation_browsertest.cc (right):

https://codereview.chromium.org/2905293002/diff/1/content/browser/browser_sid...
content/browser/browser_side_navigation_browsertest.cc:465:
process_exit_observer.Wait();
We should add a case to this test where the tab is reloaded and the renderer
tries to navigate to something illegal in base_url_for_data_url.  It looks like
the request will still succeed due to the early return, when it shouldn't.