Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2913703002: Make TextAlignLast an enum class. (Closed)

Created:
3 years, 6 months ago by nainar
Modified:
3 years, 6 months ago
Reviewers:
meade_UTC10, shend
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make TextAlignLast an enum class. This patch makes TextAlignLast an enum class for type safety. BUG=684966 Review-Url: https://codereview.chromium.org/2913703002 Cr-Commit-Position: refs/heads/master@{#475435} Committed: https://chromium.googlesource.com/chromium/src/+/41713eb8d6a74b9391f8d7580c0b296bc1b671eb

Patch Set 1 #

Patch Set 2 : make enum class #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -33 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 2 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +8 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (12 generated)
nainar
3 years, 6 months ago (2017-05-30 03:20:32 UTC) #4
shend
lgtm
3 years, 6 months ago (2017-05-30 03:26:49 UTC) #5
nainar
3 years, 6 months ago (2017-05-30 03:43:41 UTC) #9
meade_UTC10
lgtm
3 years, 6 months ago (2017-05-30 03:56:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913703002/20001
3 years, 6 months ago (2017-05-30 05:53:33 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 05:57:30 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/41713eb8d6a74b9391f8d7580c0b...

Powered by Google App Engine
This is Rietveld 408576698