Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 2915543002: Generate enum/getters/setters/mappings for text-align-last. (Closed)

Created:
3 years, 6 months ago by nainar
Modified:
3 years, 6 months ago
Reviewers:
shend, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate enum/getters/setters/mappings for text-align-last. Currently, the text-align-last property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to a 'keyword' field so that its getters/setters can be generated as well. We also generate the ETextAlignLast enum and use the generated CSSValueID <-> ETextAlignLast mappings. Diff: https://gist.github.com/7ebcc52951f3abdb9e1fd8f23bdb3e71/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2915543002 Cr-Commit-Position: refs/heads/master@{#475493} Committed: https://chromium.googlesource.com/chromium/src/+/f003932c6720ec1b62d30928d25ebc6bd9c73de9

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -84 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 1 chunk +0 lines, -53 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
nainar
3 years, 6 months ago (2017-05-30 05:22:17 UTC) #3
rune
lgtm
3 years, 6 months ago (2017-05-30 08:05:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2915543002/1
3 years, 6 months ago (2017-05-30 08:20:39 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/450521)
3 years, 6 months ago (2017-05-30 08:27:22 UTC) #12
shend
lgtm
3 years, 6 months ago (2017-05-30 11:19:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2915543002/20001
3 years, 6 months ago (2017-05-30 11:20:41 UTC) #20
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 11:29:43 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f003932c6720ec1b62d30928d25e...

Powered by Google App Engine
This is Rietveld 408576698