Made WebFactory::SetInstance private

Made WebFactory::SetInstance private

Made WebFactory::SetInstance private and only allowed WebFactoryImpl
to call it, through a new Initialize() method.

BUG=712963
Review-Url: https://codereview.chromium.org/2913613003
Cr-Commit-Position: refs/heads/master@{#476055}
Committed: https://chromium.googlesource.com/chromium/src/+/9019e7b1f9e536c2b9cc8ea7dcf22c89f9d3a0ac

[sashab, 2017-05-30 04:00:51]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 04:01:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2017-05-30 04:01:48]

sashab@chromium.org changed reviewers:
+ dcheng@chromium.org, slangley@chromium.org

[slangley, 2017-05-30 04:02:56]

lgtm

[dcheng, 2017-05-30 05:01:51]

https://codereview.chromium.org/2913613003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/exported/WebFactory.h (right):

https://codereview.chromium.org/2913613003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/exported/WebFactory.h:14: class WebFactoryImpl;
Nit: a separate forward declare isn't needed for friending

https://codereview.chromium.org/2913613003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/exported/WebFactory.h:31: friend class
WebFactoryImpl;
Though I think in this case, it could just be protected, right?

[commit-bot: I haz the power, 2017-05-30 05:17:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 05:17:04]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sashab, 2017-05-31 01:50:32]

dcheng ptal

https://codereview.chromium.org/2913613003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/exported/WebFactory.h (right):

https://codereview.chromium.org/2913613003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/exported/WebFactory.h:14: class WebFactoryImpl;
On 2017/05/30 at 05:01:51, dcheng wrote:
> Nit: a separate forward declare isn't needed for friending

Done.

https://codereview.chromium.org/2913613003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/exported/WebFactory.h:31: friend class
WebFactoryImpl;
On 2017/05/30 at 05:01:51, dcheng wrote:
> Though I think in this case, it could just be protected, right?

The "friend class" or the SetInstance method?

Moved friend class to be protected.

[sashab, 2017-05-31 01:50:37]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 01:51:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2017-05-31 01:55:59]

Oops; just realized what you meant by protected. Removed the "friend class" part
and just made the method protected.

[sashab, 2017-05-31 01:56:01]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 01:56:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 03:48:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 03:48:24]

Dry run: This issue passed the CQ dry run.

[dcheng, 2017-05-31 17:04:34]

lgtm

[sashab, 2017-05-31 22:06:24]

The CQ bit was checked by sashab@chromium.org

[sashab, 2017-05-31 22:06:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
slangley@chromium.org
Link to the patchset: https://codereview.chromium.org/2913613003/#ps40001
(title: "Moved to be protected")

[commit-bot: I haz the power, 2017-05-31 22:07:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 22:11:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496268384845050,
"parent_rev": "cf195c35d5f9cd9c90b8688e1d9c50c4cfd5522e", "commit_rev":
"9019e7b1f9e536c2b9cc8ea7dcf22c89f9d3a0ac"}

[commit-bot: I haz the power, 2017-05-31 22:12:00]

Description was changed from

==========
Made WebFactory::SetInstance private

Made WebFactory::SetInstance private and only allowed WebFactoryImpl
to call it, through a new Initialize() method.

BUG=712963
==========

to

==========
Made WebFactory::SetInstance private

Made WebFactory::SetInstance private and only allowed WebFactoryImpl
to call it, through a new Initialize() method.

BUG=712963

Review-Url: https://codereview.chromium.org/2913613003
Cr-Commit-Position: refs/heads/master@{#476055}
Committed:
https://chromium.googlesource.com/chromium/src/+/9019e7b1f9e536c2b9cc8ea7dcf2...
==========

[commit-bot: I haz the power, 2017-05-31 22:12:01]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9019e7b1f9e536c2b9cc8ea7dcf2...