Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: third_party/WebKit/Source/core/exported/WebFactory.h

Issue 2913613003: Made WebFactory::SetInstance private (Closed)
Patch Set: Moved to be protected Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/WebFactoryImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/exported/WebFactory.h
diff --git a/third_party/WebKit/Source/core/exported/WebFactory.h b/third_party/WebKit/Source/core/exported/WebFactory.h
index 49a43857624863a9dfb1146623adecd6c6d9512c..db544cc80c314f8338f6147eb8bd628df5fd2bbd 100644
--- a/third_party/WebKit/Source/core/exported/WebFactory.h
+++ b/third_party/WebKit/Source/core/exported/WebFactory.h
@@ -19,15 +19,16 @@ class WebViewClient;
// This class will be removed once all implementations are in core/ or modules/.
class CORE_EXPORT WebFactory {
public:
- // Takes ownership of |factory|.
- // TODO(sashab): Make this method private to WebKit.cpp.
- static void SetInstance(WebFactory&);
static WebFactory& GetInstance();
virtual ChromeClient* CreateChromeClient(WebViewBase*) const = 0;
virtual WebViewBase* CreateWebViewBase(WebViewClient*,
WebPageVisibilityState) const = 0;
+ protected:
+ // Takes ownership of |factory|.
+ static void SetInstance(WebFactory&);
+
private:
static WebFactory* factory_instance_;
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/WebFactoryImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698