Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2913433002:
[mus+ash] Fixes build by re-landing changes to maximize_mode_window_state (Closed)
Description[mus+ash] Fixes build by re-landing changes to maximize_mode_window_state
Breaking change - https://codereview.chromium.org/2909763002
BUG=722553, 726956
TEST=None (refactoring)
TBR=oshima@chromium.org
NOTREECHECKS=true
Review-Url: https://codereview.chromium.org/2913433002
Cr-Commit-Position: refs/heads/master@{#475195}
Committed: https://chromium.googlesource.com/chromium/src/+/14d8865d517de84e02b6ae59a7665612cdc06830
Patch Set 1 #
Messages
Total messages: 21 (15 generated)
The CQ bit was checked by varkha@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [mus+ash] Fixes build by re-landing changes to minimize_mode_window_state BUG=722553 TEST=None (refactoring) ========== to ========== [mus+ash] Fixes build by re-landing changes to minimize_mode_window_state BUG=722553 TEST=None (refactoring) TBR=oshima@chromium.org ==========
The CQ bit was unchecked by varkha@chromium.org
The CQ bit was checked by varkha@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by varkha@chromium.org
Description was changed from ========== [mus+ash] Fixes build by re-landing changes to minimize_mode_window_state BUG=722553 TEST=None (refactoring) TBR=oshima@chromium.org ========== to ========== [mus+ash] Fixes build by re-landing changes to maximize_mode_window_state Breaking change - https://codereview.chromium.org/2909763002 BUG=722553 TEST=None (refactoring) TBR=oshima@chromium.org ==========
The CQ bit was checked by varkha@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thestig@chromium.org changed reviewers: + thestig@chromium.org
lgtm You probably also need NOTREECHECKS=true, or we can open the tree when this is ready to land.
The CQ bit was unchecked by varkha@chromium.org
Description was changed from ========== [mus+ash] Fixes build by re-landing changes to maximize_mode_window_state Breaking change - https://codereview.chromium.org/2909763002 BUG=722553 TEST=None (refactoring) TBR=oshima@chromium.org ========== to ========== [mus+ash] Fixes build by re-landing changes to maximize_mode_window_state Breaking change - https://codereview.chromium.org/2909763002 BUG=722553 TEST=None (refactoring) TBR=oshima@chromium.org NOTREECHECKS=true ==========
The CQ bit was checked by varkha@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/05/27 00:52:44, Lei Zhang wrote: > lgtm > > You probably also need NOTREECHECKS=true, or we can open the tree when this is > ready to land. Thanks, added that and re-checked commit box.
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495846488350950, "parent_rev":
"7e8a1b15604183c428d3515ef46556ecd49a5eea", "commit_rev":
"14d8865d517de84e02b6ae59a7665612cdc06830"}
Message was sent while issue was closed.
Description was changed from ========== [mus+ash] Fixes build by re-landing changes to maximize_mode_window_state Breaking change - https://codereview.chromium.org/2909763002 BUG=722553 TEST=None (refactoring) TBR=oshima@chromium.org NOTREECHECKS=true ========== to ========== [mus+ash] Fixes build by re-landing changes to maximize_mode_window_state Breaking change - https://codereview.chromium.org/2909763002 BUG=722553 TEST=None (refactoring) TBR=oshima@chromium.org NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2913433002 Cr-Commit-Position: refs/heads/master@{#475195} Committed: https://chromium.googlesource.com/chromium/src/+/14d8865d517de84e02b6ae59a766... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/14d8865d517de84e02b6ae59a766...
Message was sent while issue was closed.
Description was changed from ========== [mus+ash] Fixes build by re-landing changes to maximize_mode_window_state Breaking change - https://codereview.chromium.org/2909763002 BUG=722553 TEST=None (refactoring) TBR=oshima@chromium.org NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2913433002 Cr-Commit-Position: refs/heads/master@{#475195} Committed: https://chromium.googlesource.com/chromium/src/+/14d8865d517de84e02b6ae59a766... ========== to ========== [mus+ash] Fixes build by re-landing changes to maximize_mode_window_state Breaking change - https://codereview.chromium.org/2909763002 BUG=722553, 726956 TEST=None (refactoring) TBR=oshima@chromium.org NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2913433002 Cr-Commit-Position: refs/heads/master@{#475195} Committed: https://chromium.googlesource.com/chromium/src/+/14d8865d517de84e02b6ae59a766... ========== |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
