Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2918863002: [CrOS Tether] Update the KeepAliveTickle code to receive DeviceStatus updates. (Closed)

Created:
3 years, 6 months ago by Kyle Horimoto
Modified:
3 years, 6 months ago
Reviewers:
Ryan Hansberry
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, oshima+watch_chromium.org, lesliewatkins+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CrOS Tether] Update the KeepAliveTickle code to receive DeviceStatus updates. This CL consists of three parts: (1) Update KeepAliveOperation to receive a KeepAliveTickleResponse message after sending a KeepAliveTickle message. (2) Update KeepAliveScheduler to handle a received message and record the updated information in HostScanCache. (3) Integrate KeepAliveScheduler into the app (i.e., initialize it in Initializer). BUG=672263 Review-Url: https://codereview.chromium.org/2918863002 Cr-Commit-Position: refs/heads/master@{#477362} Committed: https://chromium.googlesource.com/chromium/src/+/c2d14083b36f8b4bd8caf9031ae2ef6583d4e280

Patch Set 1 #

Patch Set 2 : Rebased. #

Total comments: 4

Patch Set 3 : hansberry@ comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -31 lines) Patch
M chromeos/components/tether/initializer.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chromeos/components/tether/initializer.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M chromeos/components/tether/keep_alive_operation.h View 1 2 3 chunks +12 lines, -7 lines 0 comments Download
M chromeos/components/tether/keep_alive_operation.cc View 2 chunks +29 lines, -2 lines 0 comments Download
M chromeos/components/tether/keep_alive_operation_unittest.cc View 1 2 4 chunks +56 lines, -2 lines 0 comments Download
M chromeos/components/tether/keep_alive_scheduler.h View 4 chunks +20 lines, -6 lines 0 comments Download
M chromeos/components/tether/keep_alive_scheduler.cc View 3 chunks +44 lines, -6 lines 0 comments Download
M chromeos/components/tether/keep_alive_scheduler_unittest.cc View 1 2 8 chunks +72 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Kyle Horimoto
3 years, 6 months ago (2017-06-01 21:38:52 UTC) #2
Ryan Hansberry
Please confirm that this works on a real device. Otherwise, lgtm. https://codereview.chromium.org/2918863002/diff/20001/chromeos/components/tether/keep_alive_operation.h File chromeos/components/tether/keep_alive_operation.h (right): ...
3 years, 6 months ago (2017-06-01 23:45:52 UTC) #3
Kyle Horimoto
https://codereview.chromium.org/2918863002/diff/20001/chromeos/components/tether/keep_alive_operation.h File chromeos/components/tether/keep_alive_operation.h (right): https://codereview.chromium.org/2918863002/diff/20001/chromeos/components/tether/keep_alive_operation.h#newcode40 chromeos/components/tether/keep_alive_operation.h:40: // |device_status| point to a valid DeviceStatus if the ...
3 years, 6 months ago (2017-06-06 18:30:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918863002/40001
3 years, 6 months ago (2017-06-06 18:31:13 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 19:13:50 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c2d14083b36f8b4bd8caf9031ae2...

Powered by Google App Engine
This is Rietveld 408576698