Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2913343002: Start removing deprecated Options UI code (Closed)

Created:
3 years, 6 months ago by Dan Beam
Modified:
3 years, 6 months ago
Reviewers:
Lei Zhang, dpapad
CC:
asvitkine+watch_chromium.org, awdf+watch_chromium.org, chromium-reviews, dbeam+watch-options_chromium.org, jdonnelly+watch_chromium.org, kalyank, michaelpg+watch-options_chromium.org, mlamouri+watch-notifications_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, Peter Beverloo, sadrul, shuchen+watch_chromium.org, tfarina, yusukes+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Start removing deprecated Options UI code This CL removes features::kMaterialDesignSettings. R=dpapad@chromium.org,thestig@chromium.org BUG=728353 Review-Url: https://codereview.chromium.org/2913343002 Cr-Commit-Position: refs/heads/master@{#477519} Committed: https://chromium.googlesource.com/chromium/src/+/e1a5fa50529b3c83abb5db46772caa79ba210f43

Patch Set 1 #

Total comments: 12

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : re-enable settings-frame #

Patch Set 4 : compile #

Total comments: 2

Patch Set 5 : thestig@ review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1829 lines) Patch
M chrome/browser/about_flags.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc View 1 2 3 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 2 3 4 1 chunk +5 lines, -21 lines 0 comments Download
M chrome/browser/browser_about_handler_unittest.cc View 2 chunks +0 lines, -45 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 chunks +8 lines, -12 lines 0 comments Download
M chrome/browser/chrome_content_browser_client_browsertest.cc View 1 2 3 2 chunks +12 lines, -112 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 2 3 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_interactive_uitest.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 3 3 chunks +0 lines, -147 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_client.cc View 1 2 3 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/chrome_pages.cc View 1 2 3 6 chunks +3 lines, -37 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 1 2 3 3 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 2 2 chunks +6 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/log_web_ui_url_browsertest.cc View 3 chunks +0 lines, -41 lines 0 comments Download
D chrome/browser/ui/webui/options/certificate_manager_browsertest.cc View 1 chunk +0 lines, -108 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/guest_mode_options_browsertest.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/guest_mode_options_browsertest.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/guest_mode_options_browsertest.js View 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/guest_mode_options_ui_browsertest.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/ui/webui/options/clear_browser_data_browsertest.cc View 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/browser/ui/webui/options/content_settings_exception_area_browsertest.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/ui/webui/options/language_dictionary_interactive_uitest.cc View 1 chunk +0 lines, -255 lines 0 comments Download
D chrome/browser/ui/webui/options/language_options_interactive_uitest.cc View 1 chunk +0 lines, -166 lines 0 comments Download
D chrome/browser/ui/webui/options/options_ui_browsertest.h View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/ui/webui/options/options_ui_browsertest.cc View 1 chunk +0 lines, -344 lines 0 comments Download
M chrome/browser/ui/webui/signin/user_manager_screen_handler.cc View 1 2 3 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/uber/uber_ui.cc View 1 chunk +2 lines, -3 lines 0 comments Download
D chrome/browser/ui/webui/uber/uber_ui_browsertest.cc View 1 chunk +0 lines, -86 lines 0 comments Download
M chrome/common/chrome_features.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_features.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/url_constants.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/url_constants.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 chunks +0 lines, -11 lines 0 comments Download
M chrome/test/data/webui/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/webui/settings/help_page_browsertest.js View 2 chunks +0 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 43 (32 generated)
Dan Beam
3 years, 6 months ago (2017-05-31 23:33:19 UTC) #3
dpapad
Overall this L-G-T-M, some nits and a question below. Also perhaps you can add a ...
3 years, 6 months ago (2017-06-01 00:12:55 UTC) #7
Dan Beam
https://codereview.chromium.org/2913343002/diff/1/chrome/browser/browser_about_handler.cc File chrome/browser/browser_about_handler.cc (right): https://codereview.chromium.org/2913343002/diff/1/chrome/browser/browser_about_handler.cc#newcode93 chrome/browser/browser_about_handler.cc:93: // Redirect chrome://settings, unless MD settings is enabled. On ...
3 years, 6 months ago (2017-06-03 00:11:03 UTC) #10
Dan Beam
+thestig@ for chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc chrome/browser/browser_about_handler.cc chrome/browser/browser_about_handler_unittest.cc chrome/browser/notifications/platform_notification_service_interactive_uitest.cc chrome/browser/policy/policy_browsertest.cc chrome/browser/ui/ash/system_tray_client.cc chrome/browser/ui/chrome_pages.cc chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
3 years, 6 months ago (2017-06-03 00:40:12 UTC) #13
Lei Zhang
https://codereview.chromium.org/2913343002/diff/20001/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc File chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc (right): https://codereview.chromium.org/2913343002/diff/20001/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc#newcode9 chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc:9: #include "base/feature_list.h" Delete? I'd just grep for FeatureList in ...
3 years, 6 months ago (2017-06-03 01:03:50 UTC) #15
Dan Beam
https://codereview.chromium.org/2913343002/diff/20001/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc File chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc (right): https://codereview.chromium.org/2913343002/diff/20001/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc#newcode9 chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc:9: #include "base/feature_list.h" On 2017/06/03 01:03:49, Lei Zhang wrote: > ...
3 years, 6 months ago (2017-06-06 03:52:50 UTC) #25
dpapad
LGTM
3 years, 6 months ago (2017-06-06 19:12:58 UTC) #31
Lei Zhang
lgtm https://codereview.chromium.org/2913343002/diff/100001/chrome/browser/browser_about_handler.cc File chrome/browser/browser_about_handler.cc (right): https://codereview.chromium.org/2913343002/diff/100001/chrome/browser/browser_about_handler.cc#newcode96 chrome/browser/browser_about_handler.cc:96: // Redirect chrome://help, unless MD settings is enabled. ...
3 years, 6 months ago (2017-06-06 21:10:54 UTC) #32
Dan Beam
https://codereview.chromium.org/2913343002/diff/100001/chrome/browser/browser_about_handler.cc File chrome/browser/browser_about_handler.cc (right): https://codereview.chromium.org/2913343002/diff/100001/chrome/browser/browser_about_handler.cc#newcode96 chrome/browser/browser_about_handler.cc:96: // Redirect chrome://help, unless MD settings is enabled. On ...
3 years, 6 months ago (2017-06-06 21:32:56 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913343002/120001
3 years, 6 months ago (2017-06-07 01:21:35 UTC) #40
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 02:27:59 UTC) #43
Message was sent while issue was closed.
Committed patchset #5 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/e1a5fa50529b3c83abb5db46772c...

Powered by Google App Engine
This is Rietveld 408576698