Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2919343005: Remove tests for deprecated Options UI (Closed)

Created:
3 years, 6 months ago by Dan Beam
Modified:
3 years, 6 months ago
Reviewers:
Lei Zhang, dpapad
CC:
chromium-reviews, dbeam+watch-options_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, mathp+autofillwatch_chromium.org, michaelpg+watch-options_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, rginda+watch_chromium.org, rogerm+autofillwatch_chromium.org, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, shuchen+watch_chromium.org, vabr+watchlistautofill_chromium.org, vabr+watchlistpasswordmanager_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove tests for deprecated Options UI R=dpapad@chromium.org BUG=728353, 315250, 434502, 559265, 559320, 559330, 560910, 570046, 570555, 570556, 570560, 570562, 570563, 570566, 570567, 570568, 570723, 603499, 605090, 608126, 616791, 660867 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2919343005 Cr-Commit-Position: refs/heads/master@{#477561} Committed: https://chromium.googlesource.com/chromium/src/+/431a97fe65ed2ad03797afc84fb0182fd3a5643c

Patch Set 1 #

Patch Set 2 : and more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8300 lines) Patch
M chrome/BUILD.gn View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/BUILD.gn View 1 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/browser/resources/options_test_resources.grd View 1 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/ui/webui/options/autofill_options_browsertest.js View 1 chunk +0 lines, -174 lines 0 comments Download
D chrome/browser/ui/webui/options/autofill_options_handler_unittest.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/ui/webui/options/browser_options_browsertest.js View 1 chunk +0 lines, -131 lines 0 comments Download
D chrome/browser/ui/webui/options/certificate_manager_browsertest.js View 1 chunk +0 lines, -405 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc View 1 chunk +0 lines, -166 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.js View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/bluetooth_options_browsertest.js View 1 chunk +0 lines, -440 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/cros_language_options_handler_unittest.cc View 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/date_time_options_browsertest.js View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/power_overlay_browsertest.js View 1 chunk +0 lines, -175 lines 0 comments Download
D chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc View 1 chunk +0 lines, -467 lines 0 comments Download
D chrome/browser/ui/webui/options/content_options_browsertest.js View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/ui/webui/options/content_settings_exception_area_browsertest.js View 1 chunk +0 lines, -109 lines 0 comments Download
D chrome/browser/ui/webui/options/cookies_view_browsertest.js View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/ui/webui/options/edit_dictionary_browsertest.js View 1 chunk +0 lines, -166 lines 0 comments Download
D chrome/browser/ui/webui/options/font_settings_browsertest.js View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/ui/webui/options/font_settings_utils_unittest.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/ui/webui/options/language_options_browsertest.js View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/ui/webui/options/language_options_dictionary_download_browsertest.js View 1 chunk +0 lines, -129 lines 0 comments Download
D chrome/browser/ui/webui/options/language_options_handler_unittest.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/ui/webui/options/manage_profile_browsertest.js View 1 chunk +0 lines, -672 lines 0 comments Download
D chrome/browser/ui/webui/options/multilanguage_options_browsertest.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/ui/webui/options/multilanguage_options_browsertest.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.js View 1 chunk +0 lines, -212 lines 0 comments Download
D chrome/browser/ui/webui/options/options_browsertest.h View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/ui/webui/options/options_browsertest.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D chrome/browser/ui/webui/options/options_browsertest.js View 1 chunk +0 lines, -969 lines 0 comments Download
D chrome/browser/ui/webui/options/options_browsertest_base.js View 1 chunk +0 lines, -86 lines 0 comments Download
D chrome/browser/ui/webui/options/password_manager_browsertest.js View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/ui/webui/options/password_manager_handler_unittest.cc View 1 chunk +0 lines, -244 lines 0 comments Download
D chrome/browser/ui/webui/options/pepper_flash_content_settings_utils_unittest.cc View 1 chunk +0 lines, -137 lines 0 comments Download
D chrome/browser/ui/webui/options/preferences_browsertest.h View 1 chunk +0 lines, -196 lines 0 comments Download
D chrome/browser/ui/webui/options/preferences_browsertest.cc View 1 chunk +0 lines, -1106 lines 0 comments Download
D chrome/browser/ui/webui/options/profile_settings_reset_browsertest.js View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/ui/webui/options/search_engine_manager_browsertest.js View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/ui/webui/options/settings_format_browsertest.js View 1 chunk +0 lines, -176 lines 0 comments Download
D chrome/browser/ui/webui/options/startup_page_list_browsertest.js View 1 chunk +0 lines, -151 lines 0 comments Download
D chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc View 1 chunk +0 lines, -951 lines 0 comments Download
M chrome/test/BUILD.gn View 3 chunks +0 lines, -14 lines 0 comments Download
M chrome/test/data/webui/BUILD.gn View 2 chunks +0 lines, -35 lines 0 comments Download
D chrome/test/data/webui/inline_editable_list_test.html View 1 1 chunk +0 lines, -152 lines 0 comments Download
M chrome/test/data/webui/webui_resource_browsertest.cc View 1 2 chunks +0 lines, -17 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (15 generated)
Dan Beam
3 years, 6 months ago (2017-06-06 21:58:36 UTC) #1
dpapad
LGTM. I tried to gather all bugs referenced by the deleted code, 25 of them ...
3 years, 6 months ago (2017-06-06 22:33:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919343005/40001
3 years, 6 months ago (2017-06-07 02:59:37 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/457432)
3 years, 6 months ago (2017-06-07 03:08:28 UTC) #15
Dan Beam
+thestig@ for tools/grit and chrome/BUILD.gn
3 years, 6 months ago (2017-06-07 03:20:58 UTC) #16
Dan Beam
+thestig@ for tools/grit and chrome/BUILD.gn (for realz)
3 years, 6 months ago (2017-06-07 03:22:44 UTC) #18
Lei Zhang
lgtm
3 years, 6 months ago (2017-06-07 05:03:17 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919343005/40001
3 years, 6 months ago (2017-06-07 06:05:17 UTC) #21
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 06:11:15 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/431a97fe65ed2ad03797afc84fb0...

Powered by Google App Engine
This is Rietveld 408576698