Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2913293002: Clean up the unpack directory for CRLSet component. (Closed)

Created:
3 years, 6 months ago by Sorin Jianu
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Clean up the unpack directory for CRLSet component. This is the iOS fix corresponding to: https://codereview.chromium.org/2906683002 In the current implementation of the component updater, the component installer owns the unpack path of a component and it is responsible for deleting the unpack path before the execution flow returns to the component updater during the update of a component. For most components, this clean up is done in the implementation of the DefaultComponentInstaller class. However, CRLSet is one of the few components which is not reusing the DefaultComponentInstaller for its component installer. As a result, it is leaking the content of the unpack path after each update cycle. It is not clear when this regression has been introduced. BUG=725671 Change-Id: Iba01e7d9210fea4da92718cff833ea1f758935bf Reviewed-on: https://chromium-review.googlesource.com/517582 Commit-Queue: Sorin Jianu <sorin@chromium.org>; Reviewed-by: Joshua Pawlicki <waffles@chromium.org>; Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#475567} Review-Url: https://codereview.chromium.org/2913293002 . Cr-Commit-Position: refs/branch-heads/3112@{#64} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/25f73c6377429afb1fe14ae9c7f625624feb5c98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ios/chrome/browser/net/crl_set_fetcher.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Sorin Jianu
3 years, 6 months ago (2017-05-31 20:40:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
25f73c6377429afb1fe14ae9c7f625624feb5c98.

Powered by Google App Engine
This is Rietveld 408576698