Clean up the unpack directory for CRLSet component.

Clean up the unpack directory for CRLSet component.

In the current implementation of the component updater, the component
installer owns the unpack path of a component and it is responsible
for deleting the unpack path before the execution flow returns to
the component updater during the update of a component.

For most components, this clean up is done in the implementation of
the DefaultComponentInstaller class. However, CRLSet is one of the few
components which is not reusing the DefaultComponentInstaller for
its component installer. As a result, it is leaking the content of
the unpack path after each update cycle.

It is not clear when this regression has been introduced.

BUG=725671
Review-Url: https://codereview.chromium.org/2906683002
Cr-Commit-Position: refs/heads/master@{#474700}
Committed: https://chromium.googlesource.com/chromium/src/+/3ef0c4a62c3bbc2cea73b2821fa6637570c94888

[Sorin Jianu, 2017-05-25 15:52:46]

The CQ bit was checked by sorin@chromium.org to run a CQ dry run

[Sorin Jianu, 2017-05-25 15:53:02]

Description was changed from

==========
Clean up the unpack directory for CRLSet component.

In the current implementation of the component updater, the component
installer owns the unpack path of a component and it is responsible
for deleting the unpack path before the execution flow returns to
the component updater during the update of a component.

For most components, this clean up is done in the implementation of
the DefaultComponentInstaller class. However, CRLSet is one of the few
components which is not reusing the DefaultComponentInstaller for
its component installer. As a result, it is leaking the content of
the unpack path after each update cycle.

It is not clear when this regression has been introduced.

BUG=725671
==========

to

==========
Clean up the unpack directory for CRLSet component.

In the current implementation of the component updater, the component
installer owns the unpack path of a component and it is responsible
for deleting the unpack path before the execution flow returns to
the component updater during the update of a component.

For most components, this clean up is done in the implementation of
the DefaultComponentInstaller class. However, CRLSet is one of the few
components which is not reusing the DefaultComponentInstaller for
its component installer. As a result, it is leaking the content of
the unpack path after each update cycle.

It is not clear when this regression has been introduced.

BUG=725671
==========

[Sorin Jianu, 2017-05-25 15:53:02]

sorin@chromium.org changed reviewers:
+ agl@chromium.org, waffles@chromium.org

[commit-bot: I haz the power, 2017-05-25 15:53:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sorin Jianu, 2017-05-25 15:54:14]

Adam, PTAL! Thank you!

[waffles, 2017-05-25 16:38:10]

lgtm

[Sorin Jianu, 2017-05-25 17:37:38]

sorin@chromium.org changed reviewers:
+ rsleevi@chromium.org

[Sorin Jianu, 2017-05-25 17:37:39]

Ryan, PTAL for an owner's approval please. Adam is not online and we'd like to
land this asap to make the stable cut in M59.
Thank you!

[commit-bot: I haz the power, 2017-05-25 17:39:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 17:39:52]

Dry run: This issue passed the CQ dry run.

[Ryan Sleevi, 2017-05-25 17:48:38]

lgtm

[Sorin Jianu, 2017-05-25 17:51:36]

The CQ bit was checked by sorin@chromium.org

[commit-bot: I haz the power, 2017-05-25 17:52:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 17:58:17]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495734696573960, "parent_rev":
"91882284e5f5d1e7442e3500a9c66ba9115f1e73", "commit_rev":
"3ef0c4a62c3bbc2cea73b2821fa6637570c94888"}

[commit-bot: I haz the power, 2017-05-25 17:58:33]

Description was changed from

==========
Clean up the unpack directory for CRLSet component.

In the current implementation of the component updater, the component
installer owns the unpack path of a component and it is responsible
for deleting the unpack path before the execution flow returns to
the component updater during the update of a component.

For most components, this clean up is done in the implementation of
the DefaultComponentInstaller class. However, CRLSet is one of the few
components which is not reusing the DefaultComponentInstaller for
its component installer. As a result, it is leaking the content of
the unpack path after each update cycle.

It is not clear when this regression has been introduced.

BUG=725671
==========

to

==========
Clean up the unpack directory for CRLSet component.

In the current implementation of the component updater, the component
installer owns the unpack path of a component and it is responsible
for deleting the unpack path before the execution flow returns to
the component updater during the update of a component.

For most components, this clean up is done in the implementation of
the DefaultComponentInstaller class. However, CRLSet is one of the few
components which is not reusing the DefaultComponentInstaller for
its component installer. As a result, it is leaking the content of
the unpack path after each update cycle.

It is not clear when this regression has been introduced.

BUG=725671

Review-Url: https://codereview.chromium.org/2906683002
Cr-Commit-Position: refs/heads/master@{#474700}
Committed:
https://chromium.googlesource.com/chromium/src/+/3ef0c4a62c3bbc2cea73b2821fa6...
==========

[commit-bot: I haz the power, 2017-05-25 17:58:34]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3ef0c4a62c3bbc2cea73b2821fa6...

[agl, 2017-05-25 20:57:48]

lgtm