Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2913213002: cros: Fix bots by using a different websocket to get system info. (Closed)

Created:
3 years, 6 months ago by jdufault
Modified:
3 years, 6 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

cros: Fix bots by using a different websocket to get system info. This effectively reverts [1], which collapsed the usage to one websocket. 1: https://codereview.chromium.org/2904193002. BUG=chromium:726917 Review-Url: https://codereview.chromium.org/2913213002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/e5a3040e387b5d1632e65faac40ddd404118ba1e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/internal/backends/chrome_inspector/system_info_backend.py View 1 chunk +12 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
jdufault
nednguyen@ PTAL
3 years, 6 months ago (2017-05-31 17:57:12 UTC) #5
nednguyen
lgtm
3 years, 6 months ago (2017-05-31 18:28:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913213002/1
3 years, 6 months ago (2017-05-31 18:44:27 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Presubmit/builds/7346)
3 years, 6 months ago (2017-05-31 18:55:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913213002/1
3 years, 6 months ago (2017-05-31 20:17:35 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 20:19:11 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698