Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2913103003: Revert of M59: Linux: Make manual libnss3 version dependency work again. (Closed)

Created:
3 years, 6 months ago by tyoshino (SeeGerritForStatus)
Modified:
3 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Revert of M59: Linux: Make manual libnss3 version dependency work again. (patchset #1 id:1 of https://codereview.chromium.org/2910253002/ ) Reason for revert: Looks this broke the stable builder. https://bugs.chromium.org/p/chromium/issues/detail?id=727996 Original issue's description: > M59: Linux: Make manual libnss3 version dependency work again. > > When libnss3 is specified as a dependency both manually and via > dpkg-shlibdeps, only the dpkg-shlibdeps dependency actually makes it > into the .deb file's Depends section. To work around this, remove the > entry generated by dpkg-shlibdeps, after comparing it to expectations. > > This used to work, but something changed during the Jessie sysroot > update. > > BUG=691261, 726858 > > Review-Url: https://codereview.chromium.org/2903253005 > Cr-Original-Commit-Position: refs/heads/master@{#475215} > Review-Url: https://codereview.chromium.org/2910253002 . > Cr-Commit-Position: refs/branch-heads/3071@{#722} > Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} > Committed: https://chromium.googlesource.com/chromium/src/+/ce1be06c2ea023c7a41852a9002fdb5cc690bc80 TBR=thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=691261, 726858 Review-Url: https://codereview.chromium.org/2913103003 Cr-Commit-Position: refs/branch-heads/3071@{#728} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/1c22d9bc4c094b6c20e096d4b1fd6bc906f066e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -24 lines) Patch
M chrome/installer/linux/debian/build.sh View 3 chunks +5 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
tyoshino (SeeGerritForStatus)
Created Revert of M59: Linux: Make manual libnss3 version dependency work again.
3 years, 6 months ago (2017-05-31 05:17:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913103003/1
3 years, 6 months ago (2017-05-31 05:18:08 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 05:18:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1c22d9bc4c094b6c20e096d4b1fd...

Powered by Google App Engine
This is Rietveld 408576698