Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2910253002: M59: Linux: Make manual libnss3 version dependency work again. (Closed)

Created:
3 years, 6 months ago by Lei Zhang
Modified:
3 years, 6 months ago
Reviewers:
Tom Anderson
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

M59: Linux: Make manual libnss3 version dependency work again. When libnss3 is specified as a dependency both manually and via dpkg-shlibdeps, only the dpkg-shlibdeps dependency actually makes it into the .deb file's Depends section. To work around this, remove the entry generated by dpkg-shlibdeps, after comparing it to expectations. This used to work, but something changed during the Jessie sysroot update. BUG=691261, 726858 Review-Url: https://codereview.chromium.org/2903253005 Cr-Original-Commit-Position: refs/heads/master@{#475215} Review-Url: https://codereview.chromium.org/2910253002 . Cr-Commit-Position: refs/branch-heads/3071@{#722} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/ce1be06c2ea023c7a41852a9002fdb5cc690bc80

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M chrome/installer/linux/debian/build.sh View 3 chunks +24 lines, -5 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
Committed patchset #1 (id:1) manually as ce1be06c2ea023c7a41852a9002fdb5cc690bc80.
3 years, 6 months ago (2017-05-30 19:09:32 UTC) #2
tyoshino (SeeGerritForStatus)
Looks this broke the stable builder. https://bugs.chromium.org/p/chromium/issues/detail?id=727996
3 years, 6 months ago (2017-05-31 05:17:35 UTC) #3
tyoshino (SeeGerritForStatus)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2913103003/ by tyoshino@chromium.org. ...
3 years, 6 months ago (2017-05-31 05:17:50 UTC) #4
Tom Anderson
https://codereview.chromium.org/2910253002/diff/1/chrome/installer/linux/debian/build.sh File chrome/installer/linux/debian/build.sh (right): https://codereview.chromium.org/2910253002/diff/1/chrome/installer/linux/debian/build.sh#newcode328 chrome/installer/linux/debian/build.sh:328: libnss3 (>= 3.17.2), lsb-base (>=4.1), xdg-utils (>= 1.0.2), wget" ...
3 years, 6 months ago (2017-05-31 05:43:14 UTC) #6
Lei Zhang
3 years, 6 months ago (2017-05-31 07:13:13 UTC) #7
Message was sent while issue was closed.
On 2017/05/31 05:43:14, Tom Anderson wrote:
>
https://codereview.chromium.org/2910253002/diff/1/chrome/installer/linux/debi...
> File chrome/installer/linux/debian/build.sh (right):
> 
>
https://codereview.chromium.org/2910253002/diff/1/chrome/installer/linux/debi...
> chrome/installer/linux/debian/build.sh:328: libnss3 (>= 3.17.2), lsb-base
> (>=4.1), xdg-utils (>= 1.0.2), wget"
> I guess ">=4.1" should have been ">= 4.1" for lsb-base

Ya, that was a pre-existing condition.

Powered by Google App Engine
This is Rietveld 408576698