third_party/WebKit/Source/core/layout/LayoutGrid.h - Issue 2913093002: Revert of [css-align] Don't resolve 'auto' values for computed style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.h

Issue 2913093002: Revert of [css-align] Don't resolve 'auto' values for computed style. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutGrid.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.h b/third_party/WebKit/Source/core/layout/LayoutGrid.h

index 767b5bff6f3b99104c6ea00f68c23c414351a909..34b5414d604dc05e004ba0ce788b2953dcb238e3 100644

--- a/third_party/WebKit/Source/core/layout/LayoutGrid.h

+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.h

@@ -128,14 +128,6 @@

LayoutObject* before_child = nullptr) override;

void RemoveChild(LayoutObject*) override;

- bool SelfAlignmentChangedToStretch(GridAxis,

- const ComputedStyle& old_style,

- const ComputedStyle& new_style,

- const LayoutBox&) const;

- bool SelfAlignmentChangedFromStretch(GridAxis,

- const ComputedStyle& old_style,

- const ComputedStyle& new_style,

- const LayoutBox&) const;

void StyleDidChange(StyleDifference, const ComputedStyle*) override;

Optional<LayoutUnit> AvailableSpaceForGutters(GridTrackSizingDirection) const;

@@ -219,16 +211,8 @@

LayoutUnit AvailableAlignmentSpaceForChildBeforeStretching(

LayoutUnit grid_area_breadth_for_child,

const LayoutBox&) const;

- StyleSelfAlignmentData JustifySelfForChild(

- const LayoutBox&,

- const ComputedStyle* = nullptr) const;

- StyleSelfAlignmentData AlignSelfForChild(

- const LayoutBox&,

- const ComputedStyle* = nullptr) const;

- StyleSelfAlignmentData SelfAlignmentForChild(

- GridAxis,

- const LayoutBox& child,

- const ComputedStyle* = nullptr) const;

+ StyleSelfAlignmentData JustifySelfForChild(const LayoutBox&) const;

+ StyleSelfAlignmentData AlignSelfForChild(const LayoutBox&) const;

void ApplyStretchAlignmentToChildIfNeeded(LayoutBox&);

bool HasAutoSizeInColumnAxis(const LayoutBox& child) const {

return IsHorizontalWritingMode() ? child.StyleRef().Height().IsAuto()