Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2913003003: Add version of TextIterator constructor that takes EphemeralRange (Closed)

Created:
3 years, 6 months ago by rlanday
Modified:
3 years, 6 months ago
Reviewers:
yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add version of TextIterator constructor that takes EphemeralRange Currently TextIterator's constructor takes two Positions (start and end). It came up during review of https://codereview.chromium.org/2901213008 that it would be helpful to have another version of the constructor that instead takes an EphemeralRange. BUG= Review-Url: https://codereview.chromium.org/2913003003 Cr-Commit-Position: refs/heads/master@{#475736} Committed: https://chromium.googlesource.com/chromium/src/+/e50a33061a1efd977881cc37eb53e762497393c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M third_party/WebKit/Source/core/editing/iterators/TextIterator.h View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
rlanday
3 years, 6 months ago (2017-05-30 22:16:39 UTC) #3
Xiaocheng
lgtm
3 years, 6 months ago (2017-05-30 22:30:31 UTC) #5
yosin_UTC9
lgtm Thanks for doing this! Once the patch[1] is committed, we can deprecate |Position| version ...
3 years, 6 months ago (2017-05-31 01:52:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2913003003/1
3 years, 6 months ago (2017-05-31 01:53:44 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 01:59:21 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e50a33061a1efd977881cc37eb53...

Powered by Google App Engine
This is Rietveld 408576698