Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2912863005: Use MDCTypography instead of MDFRobotoFontLoader directly. (Closed)

Created:
3 years, 6 months ago by lpromero
Modified:
3 years, 6 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, jdonnelly+watch_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, pkl (ping after 24h if needed), raymes+watch_chromium.org, vabr+watchlistautofill_chromium.org, lgarron+watch_chromium.org, noyau+watch_chromium.org, mathp+autofillwatch_chromium.org, tfarina, marq+watch_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, stkhapugin, ios-reviews+showcase_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use MDCTypography instead of MDFRobotoFontLoader directly. That way, Showcase and CSChromium can opt-out of Roboto and get San Francisco. BUG=694948 R=sdefresne@chromium.org Review-Url: https://codereview.chromium.org/2912863005 Cr-Commit-Position: refs/heads/master@{#476333} Committed: https://chromium.googlesource.com/chromium/src/+/2657632ce7da40b8cb1de9d5e09ee7f1a36799d0

Patch Set 1 #

Patch Set 2 : Revert main_controller #

Total comments: 1

Patch Set 3 : Revert uses of Material helpers #

Patch Set 4 : Rebased #

Patch Set 5 : Update target value in unit test #

Total comments: 1

Patch Set 6 : Tentative fix for ManualTextFramerTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -238 lines) Patch
M ios/chrome/browser/passwords/password_generation_prompt_view.mm View 4 chunks +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/alert_coordinator/loading_alert_coordinator.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm View 2 chunks +5 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/autofill/cells/autofill_edit_item.mm View 1 2 3 2 chunks +3 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/autofill/cells/cvc_item.mm View 1 2 4 chunks +4 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/autofill/cells/status_item.mm View 2 chunks +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/autofill/cells/storage_switch_item.mm View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/autofill/storage_switch_tooltip.mm View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_collection_view_background.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/bookmark_promo_cell.mm View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/bookmarks/cells/bookmark_parent_folder_item.mm View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/collection_view/cells/MDCCollectionViewCell+Chrome_unittest.mm View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/collection_view/cells/collection_view_account_item.mm View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/collection_view/cells/collection_view_detail_item.mm View 1 2 3 4 5 3 chunks +3 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/collection_view/cells/collection_view_footer_item.mm View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/collection_view/cells/collection_view_switch_item.mm View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.mm View 1 2 3 chunks +3 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/contextual_search_promo_view.mm View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/downloads/download_manager_controller.mm View 2 chunks +1 line, -2 lines 0 comments Download
M ios/chrome/browser/ui/first_run/welcome_to_chrome_view.mm View 4 chunks +5 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/history/favicon_view_provider.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/history/history_entry_item.mm View 1 2 2 chunks +4 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/history/tab_history_cell.mm View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/history/tab_history_popup_controller.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/ntp/incognito_panel_controller.mm View 1 2 4 chunks +4 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/ntp/recent_tabs/views/generic_section_header_view.mm View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/ntp/recent_tabs/views/panel_bar_view.mm View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M ios/chrome/browser/ui/ntp/recent_tabs/views/session_section_header_view.mm View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M ios/chrome/browser/ui/ntp/recent_tabs/views/session_tab_data_view.mm View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/ntp/recent_tabs/views/show_full_history_view.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/ntp/recent_tabs/views/signed_in_sync_in_progress_view.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/ntp/whats_new_header_view.mm View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/location_bar_controller_impl.mm View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/omnibox_popup_material_view_controller.mm View 1 2 6 chunks +11 lines, -12 lines 0 comments Download
M ios/chrome/browser/ui/omnibox/page_info_view_controller.mm View 2 chunks +1 line, -2 lines 0 comments Download
M ios/chrome/browser/ui/payments/cells/page_info_item.mm View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_view_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/reading_list/number_badge_view.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/reading_list/reading_list_empty_collection_background.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/sad_tab/sad_tab_view.mm View 1 2 3 5 chunks +5 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/settings/cells/account_signin_item.mm View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/settings/cells/autofill_data_item.mm View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/settings/cells/card_multiline_item.mm View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/settings/cells/copied_to_chrome_item.mm View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/settings/cells/encryption_item.mm View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/settings/cells/import_data_multiline_detail_cell.mm View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/settings/cells/native_app_item.mm View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/settings/cells/passphrase_error_item.mm View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/settings/cells/password_details_item.mm View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/settings/cells/sync_switch_item.mm View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/settings/cells/text_and_error_item.mm View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/settings/cells/version_item.mm View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.mm View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/toolbar/toolbar_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_view_item.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/util/manual_text_framer_unittest.mm View 1 2 3 4 5 17 chunks +24 lines, -36 lines 0 comments Download
M ios/chrome/browser/ui/util/text_region_mapper_unittest.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ios/showcase/core/app_delegate.mm View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 37 (23 generated)
lpromero
PTAL
3 years, 6 months ago (2017-05-30 09:06:05 UTC) #3
sdefresne
https://codereview.chromium.org/2912863005/diff/20001/ios/chrome/browser/ui/bookmarks/bookmark_promo_cell.mm File ios/chrome/browser/ui/bookmarks/bookmark_promo_cell.mm (right): https://codereview.chromium.org/2912863005/diff/20001/ios/chrome/browser/ui/bookmarks/bookmark_promo_cell.mm#newcode91 ios/chrome/browser/ui/bookmarks/bookmark_promo_cell.mm:91: _subtitleLabel.font = [MDCTypography body1Font]; Why change some calls like ...
3 years, 6 months ago (2017-05-30 09:23:36 UTC) #4
lpromero
Done.
3 years, 6 months ago (2017-05-30 10:23:42 UTC) #5
lpromero
Ping
3 years, 6 months ago (2017-05-31 11:58:31 UTC) #6
sdefresne
lgtm
3 years, 6 months ago (2017-05-31 12:50:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912863005/40001
3 years, 6 months ago (2017-05-31 12:50:55 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/222367) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 6 months ago (2017-05-31 12:54:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912863005/60001
3 years, 6 months ago (2017-05-31 13:06:18 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/227239)
3 years, 6 months ago (2017-05-31 14:20:31 UTC) #19
lpromero
https://codereview.chromium.org/2912863005/diff/80001/ios/chrome/browser/ui/collection_view/cells/MDCCollectionViewCell+Chrome_unittest.mm File ios/chrome/browser/ui/collection_view/cells/MDCCollectionViewCell+Chrome_unittest.mm (right): https://codereview.chromium.org/2912863005/diff/80001/ios/chrome/browser/ui/collection_view/cells/MDCCollectionViewCell+Chrome_unittest.mm#newcode55 ios/chrome/browser/ui/collection_view/cells/MDCCollectionViewCell+Chrome_unittest.mm:55: EXPECT_NEAR(heightForWidth(100), 115, 5); With Roboto, heightForWidth(100) returns 114.5. With ...
3 years, 6 months ago (2017-05-31 15:14:49 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912863005/80001
3 years, 6 months ago (2017-05-31 15:15:32 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/227344)
3 years, 6 months ago (2017-05-31 16:06:35 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912863005/100001
3 years, 6 months ago (2017-06-01 17:01:14 UTC) #34
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 17:09:21 UTC) #37
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/2657632ce7da40b8cb1de9d5e09e...

Powered by Google App Engine
This is Rietveld 408576698