ios/chrome/browser/ui/collection_view/cells/collection_view_detail_item.mm - Issue 2912863005: Use MDCTypography instead of MDFRobotoFontLoader directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/collection_view/cells/collection_view_detail_item.mm

Issue 2912863005: Use MDCTypography instead of MDFRobotoFontLoader directly. (Closed)

Patch Set: Tentative fix for ManualTextFramerTest Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/collection_view/cells/collection_view_account_item.mm ('k') | ios/chrome/browser/ui/collection_view/cells/collection_view_footer_item.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/collection_view/cells/collection_view_detail_item.mm

diff --git a/ios/chrome/browser/ui/collection_view/cells/collection_view_detail_item.mm b/ios/chrome/browser/ui/collection_view/cells/collection_view_detail_item.mm

index ef0f9e61d9dd4d2151f4a298002aa92593033ab2..1c5d40b6f30fd562b8de5208d25cc8fd81aa3340 100644

--- a/ios/chrome/browser/ui/collection_view/cells/collection_view_detail_item.mm

+++ b/ios/chrome/browser/ui/collection_view/cells/collection_view_detail_item.mm

@@ -7,7 +7,7 @@

#include <algorithm>

#import "ios/third_party/material_components_ios/src/components/Palettes/src/MaterialPalettes.h"

-#import "ios/third_party/material_roboto_font_loader_ios/src/src/MaterialRobotoFontLoader.h"

+#import "ios/third_party/material_components_ios/src/components/Typography/src/MaterialTypography.h"

#if !defined(__has_feature) || !__has_feature(objc_arc)

#error "This file requires ARC support."

@@ -72,8 +72,7 @@ const CGFloat kMinDetailTextWidthRatio = 0.25f;

_textLabel.backgroundColor = [UIColor clearColor];

[contentView addSubview:_textLabel];

- _textLabel.font =

- [[MDFRobotoFontLoader sharedInstance] mediumFontOfSize:14];

+ _textLabel.font = [[MDCTypography fontLoader] mediumFontOfSize:14];

_textLabel.textColor = [[MDCPalette greyPalette] tint900];

_detailTextLabel = [[UILabel alloc] init];

@@ -81,8 +80,7 @@ const CGFloat kMinDetailTextWidthRatio = 0.25f;

_detailTextLabel.backgroundColor = [UIColor clearColor];

[contentView addSubview:_detailTextLabel];

- _detailTextLabel.font =

- [[MDFRobotoFontLoader sharedInstance] regularFontOfSize:14];

+ _detailTextLabel.font = [[MDCTypography fontLoader] regularFontOfSize:14];

_detailTextLabel.textColor = [[MDCPalette greyPalette] tint500];

// Set up the width constraints. They are activated here and updated in