Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2912603002: bluetooth: macOS: Adding Mac suffix (Closed)

Created:
3 years, 6 months ago by jlebel
Modified:
3 years, 6 months ago
Reviewers:
ortuno
CC:
chromium-reviews, mac-reviews_chromium.org, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: macOS: Adding Mac suffix Adding Mac suffix to the following methods to keep consistency: BluetoothLowEnergyDeviceMac::GetBluetoothRemoteGattService() BluetoothLowEnergyDeviceMac::GetBluetoothRemoteGattDescriptor() BUG=727020 Review-Url: https://codereview.chromium.org/2912603002 Cr-Commit-Position: refs/heads/master@{#475397} Committed: https://chromium.googlesource.com/chromium/src/+/78a4bf70e96b31083ca6255ef9f9c3c81b5e5653

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M device/bluetooth/bluetooth_low_energy_device_mac.h View 1 chunk +2 lines, -2 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_device_mac.mm View 11 chunks +12 lines, -12 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (6 generated)
jlebel
Hello Giovanni, Can you review this small patch about naming convention? Thanks,
3 years, 6 months ago (2017-05-28 12:42:15 UTC) #4
ortuno
lgtm
3 years, 6 months ago (2017-05-29 22:28:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912603002/1
3 years, 6 months ago (2017-05-29 22:33:48 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 00:10:09 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/78a4bf70e96b31083ca6255ef9f9...

Powered by Google App Engine
This is Rietveld 408576698