bluetooth: macOS: Removing intermediate methods in BluetoothRemoteServiceMac

bluetooth: macOS: Removing intermediate methods in BluetoothRemoteServiceMac

Making BluetoothRemoteGattDeviceMac call directly characteristic methods instead
going through intermediate methods from BluetoothRemoteGattServiceMac.

Removing:
void BluetoothRemoteGattServiceMac::DidUpdateValue(CBCharacteristic*, NSError*)
void BluetoothRemoteGattServiceMac::DidWriteValue(CBCharacteristic*, NSError*)
void BluetoothRemoteGattServiceMac::DidUpdateNotificationState(CBCharacteristic*, NSError*)


BUG=727112
Review-Url: https://codereview.chromium.org/2904363002
Cr-Commit-Position: refs/heads/master@{#479346}
Committed: https://chromium.googlesource.com/chromium/src/+/be89d3153d2c173742d473cc3e5b04e12770c507

[jlebel, 2017-05-28 12:15:00]

Patchset #1 (id:1) has been deleted

[jlebel, 2017-05-28 12:30:06]

Description was changed from

==========
bluetooth: macOS: Removing intermediate methods in BluetoothRemoteServiceMac

BUG=
==========

to

==========
bluetooth: macOS: Removing intermediate methods in BluetoothRemoteServiceMac

Making BluetoothRemoteGattDeviceMac call directly characteristic methods instead
going through intermediate methods from BluetoothRemoteGattServiceMac.

Removing:
void BluetoothRemoteGattServiceMac::DidUpdateValue(CBCharacteristic*, NSError*)
void BluetoothRemoteGattServiceMac::DidWriteValue(CBCharacteristic*, NSError*)
void
BluetoothRemoteGattServiceMac::DidUpdateNotificationState(CBCharacteristic*,
NSError*)


BUG=727112
==========

[jlebel, 2017-05-28 12:40:57]

Patchset #1 (id:20001) has been deleted

[jlebel, 2017-06-13 21:25:34]

jlebel@chromium.org changed reviewers:
+ scheib@chromium.org

[jlebel, 2017-06-13 21:25:34]

Hello Vincent,

Can you review this patch to remove intermediate methods in
BluetoothRemoteServiceMac?

Thanks,

[scheib, 2017-06-14 03:45:57]

The CQ bit was checked by scheib@chromium.org

[scheib, 2017-06-14 03:45:57]

lgtm

[commit-bot: I haz the power, 2017-06-14 03:46:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 03:48:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 03:48:05]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jlebel, 2017-06-14 09:03:16]

The CQ bit was checked by jlebel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 09:03:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 10:23:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 10:23:06]

Dry run: This issue passed the CQ dry run.

[jlebel, 2017-06-14 10:50:49]

The CQ bit was checked by jlebel@chromium.org

[jlebel, 2017-06-14 10:50:50]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/2904363002/#ps60001
(title: "Merge")

[commit-bot: I haz the power, 2017-06-14 10:51:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 10:57:18]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497437449658060,
"parent_rev": "8037a88c7d80393617d2577febf33651c198a2e3", "commit_rev":
"be89d3153d2c173742d473cc3e5b04e12770c507"}

[commit-bot: I haz the power, 2017-06-14 10:57:29]

Description was changed from

==========
bluetooth: macOS: Removing intermediate methods in BluetoothRemoteServiceMac

Making BluetoothRemoteGattDeviceMac call directly characteristic methods instead
going through intermediate methods from BluetoothRemoteGattServiceMac.

Removing:
void BluetoothRemoteGattServiceMac::DidUpdateValue(CBCharacteristic*, NSError*)
void BluetoothRemoteGattServiceMac::DidWriteValue(CBCharacteristic*, NSError*)
void
BluetoothRemoteGattServiceMac::DidUpdateNotificationState(CBCharacteristic*,
NSError*)


BUG=727112
==========

to

==========
bluetooth: macOS: Removing intermediate methods in BluetoothRemoteServiceMac

Making BluetoothRemoteGattDeviceMac call directly characteristic methods instead
going through intermediate methods from BluetoothRemoteGattServiceMac.

Removing:
void BluetoothRemoteGattServiceMac::DidUpdateValue(CBCharacteristic*, NSError*)
void BluetoothRemoteGattServiceMac::DidWriteValue(CBCharacteristic*, NSError*)
void
BluetoothRemoteGattServiceMac::DidUpdateNotificationState(CBCharacteristic*,
NSError*)


BUG=727112

Review-Url: https://codereview.chromium.org/2904363002
Cr-Commit-Position: refs/heads/master@{#479346}
Committed:
https://chromium.googlesource.com/chromium/src/+/be89d3153d2c173742d473cc3e5b...
==========

[commit-bot: I haz the power, 2017-06-14 10:57:31]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/be89d3153d2c173742d473cc3e5b...