Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 2912403004: [Mac] Mirror bookmark bubble folder dropdown in RTL (Closed)

Created:
3 years, 6 months ago by lgrey
Modified:
3 years, 6 months ago
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Mirror bookmark bubble folder dropdown in RTL BUG=726398 Review-Url: https://codereview.chromium.org/2912403004 Cr-Commit-Position: refs/heads/master@{#477391} Committed: https://chromium.googlesource.com/chromium/src/+/0add335f1a4952e84d7a491cbdc0bc2d557206c7

Patch Set 1 #

Total comments: 2

Patch Set 2 : CL comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
lgrey
You'd think this would happen automatically! PTAL :)
3 years, 6 months ago (2017-05-31 22:09:43 UTC) #2
Sidney San Martín
lgtm with nit https://codereview.chromium.org/2912403004/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm (right): https://codereview.chromium.org/2912403004/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm#newcode335 chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm:335: [folderPopUpButton_ setAlignment:NSNaturalTextAlignment]; nit: It looks like ...
3 years, 6 months ago (2017-06-01 18:52:19 UTC) #3
lgrey
Thanks! +Elly for OWNERS https://codereview.chromium.org/2912403004/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm (right): https://codereview.chromium.org/2912403004/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm#newcode335 chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm:335: [folderPopUpButton_ setAlignment:NSNaturalTextAlignment]; On 2017/06/01 18:52:19, ...
3 years, 6 months ago (2017-06-02 16:10:18 UTC) #5
lgrey
+ avi@ for OWNERS since Elly's at the summit this week
3 years, 6 months ago (2017-06-06 18:45:48 UTC) #7
Avi (use Gerrit)
lgtm owner stamp
3 years, 6 months ago (2017-06-06 19:51:39 UTC) #8
lgrey
Thanks!
3 years, 6 months ago (2017-06-06 20:08:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2912403004/20001
3 years, 6 months ago (2017-06-06 20:09:38 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 20:34:28 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0add335f1a4952e84d7a491cbdc0...

Powered by Google App Engine
This is Rietveld 408576698