[Mac] Mirror bookmark bubble folder dropdown in RTL

[Mac] Mirror bookmark bubble folder dropdown in RTL

BUG=726398
Review-Url: https://codereview.chromium.org/2912403004
Cr-Commit-Position: refs/heads/master@{#477391}
Committed: https://chromium.googlesource.com/chromium/src/+/0add335f1a4952e84d7a491cbdc0bc2d557206c7

[lgrey, 2017-05-31 22:09:43]

lgrey@chromium.org changed reviewers:
+ sdy@chromium.org

[lgrey, 2017-05-31 22:09:43]

You'd think this would happen automatically!

PTAL :)

[Sidney San Martín, 2017-06-01 18:52:19]

lgtm with nit

https://codereview.chromium.org/2912403004/diff/1/chrome/browser/ui/cocoa/boo...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm (right):

https://codereview.chromium.org/2912403004/diff/1/chrome/browser/ui/cocoa/boo...
chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm:335:
[folderPopUpButton_ setAlignment:NSNaturalTextAlignment];
nit: It looks like this is only needed because folderPopUpButton_ comes from a
nib. Could you add a comment about that?

[lgrey, 2017-06-02 16:10:17]

lgrey@chromium.org changed reviewers:
+ ellyjones@chromium.org

[lgrey, 2017-06-02 16:10:18]

Thanks! +Elly for OWNERS

https://codereview.chromium.org/2912403004/diff/1/chrome/browser/ui/cocoa/boo...
File chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm (right):

https://codereview.chromium.org/2912403004/diff/1/chrome/browser/ui/cocoa/boo...
chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm:335:
[folderPopUpButton_ setAlignment:NSNaturalTextAlignment];
On 2017/06/01 18:52:19, Sidney San Martín wrote:
> nit: It looks like this is only needed because folderPopUpButton_ comes from a
> nib. Could you add a comment about that?

Done.

[lgrey, 2017-06-06 18:45:47]

lgrey@chromium.org changed reviewers:
+ avi@chromium.org
- ellyjones@chromium.org

[lgrey, 2017-06-06 18:45:48]

+ avi@ for OWNERS since Elly's at the summit this week

[Avi (use Gerrit), 2017-06-06 19:51:39]

lgtm

owner stamp

[lgrey, 2017-06-06 20:08:58]

Thanks!

[lgrey, 2017-06-06 20:09:01]

The CQ bit was checked by lgrey@chromium.org

[lgrey, 2017-06-06 20:09:02]

The patchset sent to the CQ was uploaded after l-g-t-m from sdy@chromium.org
Link to the patchset: https://codereview.chromium.org/2912403004/#ps20001
(title: "CL comment")

[commit-bot: I haz the power, 2017-06-06 20:09:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 20:34:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496779741765020,
"parent_rev": "4309919f5a61e0701e073f21ed312e4d14cfc322", "commit_rev":
"0add335f1a4952e84d7a491cbdc0bc2d557206c7"}

[commit-bot: I haz the power, 2017-06-06 20:34:27]

Description was changed from

==========
[Mac] Mirror bookmark bubble folder dropdown in RTL

BUG=726398
==========

to

==========
[Mac] Mirror bookmark bubble folder dropdown in RTL

BUG=726398

Review-Url: https://codereview.chromium.org/2912403004
Cr-Commit-Position: refs/heads/master@{#477391}
Committed:
https://chromium.googlesource.com/chromium/src/+/0add335f1a4952e84d7a491cbdc0...
==========

[commit-bot: I haz the power, 2017-06-06 20:34:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0add335f1a4952e84d7a491cbdc0...