[Mac] Mirror bookmark bubble folder dropdown in RTL

chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.h"
 
 #include "base/mac/bundle_locations.h"
 #include "base/metrics/user_metrics.h"
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/browser/ui/bookmarks/bookmark_bubble_observer.h"
@@ skipping 311 matching lines @@
   // Info bubble view to:
   // - Fix the leading margin on the title.
   // - Flip containers.
   cocoa_l10n_util::FlipAllSubviewsIfNecessary([bigTitle_ superview]);
   // Margin on the labels.
   cocoa_l10n_util::FlipAllSubviewsIfNecessary(fieldLabelsContainer_);
   // Margin on the fields.
   cocoa_l10n_util::FlipAllSubviewsIfNecessary([nameTextField_ superview]);
   // Relative order of the done and options buttons.
   cocoa_l10n_util::FlipAllSubviewsIfNecessary(trailingButtonContainer_);
+  if (cocoa_l10n_util::ShouldDoExperimentalRTLLayout()) {
+    [folderPopUpButton_ setUserInterfaceLayoutDirection:
+                            NSUserInterfaceLayoutDirectionRightToLeft];
+    [folderPopUpButton_ setAlignment:NSNaturalTextAlignment];

[Sidney San Martín, 2017/06/01 18:52:19]

nit: It looks like this is only needed because folderPopUpButton_ comes from a
nib. Could you add a comment about that?

[lgrey, 2017/06/02 16:10:18]

Done.

+  }
 }
 
 @end  // BookmarkBubbleController
 
 
 @implementation BookmarkBubbleController (ExposedForUnitTesting)
 
 - (NSView*)syncPromoPlaceholder {
   return syncPromoPlaceholder_;
 }
@@ skipping 48 matching lines @@
   NSInteger idx = [menu indexOfItemWithRepresentedObject:parentValue];
   DCHECK(idx != -1);
   [folderPopUpButton_ selectItemAtIndex:idx];
 }
 
 - (NSPopUpButton*)folderPopUpButton {
   return folderPopUpButton_;
 }
 
 @end  // implementation BookmarkBubbleController(ExposedForUnitTesting)